feat: dogecoin #2185
Merged
feat: dogecoin #2185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add dogecoin else if to handleSend :( add dogecoin case to handleSendMax :( :(
|
@asamere @kaladinlight FYI fleek env vars added, flag is off everywhere, all environments including app and private are currently pointed at dev doggy cluster |
elmutt
previously approved these changes
Jul 20, 2022
|
i just wanna fix this real quick |
There was a problem hiding this comment.
Tested locally and it looks good overall:
- On a derived Doge account without any balance yet, live Tx history update from websocket worked and I was able to see the incoming Tx as well as balance update
- Account/asset price/balance charts are working
- Dashboard balance is taking into account the Doge balance
Spotted two things here however:
- Doge isn't in the trade assets list with the Thor flag off (which is correct) but it should be here with the flag on?
- In addition to the bug in the accounts list spotted by @0xdef1cafe, I've noticed that the Dogecoin account section is expandable with the "Show tokens (1)" button, which doesn't look like expected behavior, since it is an UTXO without a tokens standard
|
@gomesalexandre i added the label - will fix the expansion thing now too, good catch 🙏 |
|
and @gomesalexandre nah, @elmutt is getting BTC working with thor first, and then will generalize to the other UTXOs |
|
@gomesalexandre account page fixed
i'm good with this if you are 🐶 |
0xdef1cafe
approved these changes
Jul 20, 2022
elmutt
approved these changes
Jul 20, 2022
gomesalexandre
approved these changes
Jul 20, 2022
0xApotheosis
approved these changes
Jul 21, 2022
stackedq
pushed a commit
that referenced
this pull request
Jul 21, 2022
* feat: dogecoin initial * add dogecoin * use p2pkh accountType for dgubs add dogecoin else if to handleSend :( add dogecoin case to handleSendMax :( :( * wrap doge plugin in a feature flag * pass chainId to utxoAccountParams * remove reference to dogecoin testnet * web clean up * fix: update old utility to new caip method * chore: add REACT_APP_FEATURE_DOGECOIN=true to sample.env * fix: update swapper logic to pass correct param * chore: version bump doge libs * fix: add dogecoin label to accounts page * fix: don't show tokens under dogecoin account Co-authored-by: 0xdef1cafe <[email protected]> Co-authored-by: Apotheosis <[email protected]>
0xdef1cafe
added a commit
that referenced
this pull request
Jul 25, 2022
* chore: update packages * chore: add new headers * feat: add new translations * feat: add fiat market data * feat: fetch fiat market data in app context * chore: blacklist large things from redux store * fix: more correct type defs and balance chart fixes * chore: fix headers comment * chore: consolidate to priceAtDate * chore: only upgrade market service package * chore: use same source of truth for mock test data as real data structure * fix: optimizations and bug fixes * fix: market data refetch * chore: rename booleans for readability * chore: tighter type def for setFiatMarketData * chore: freeze initial price history for safety * chore: uppercase const * chore: consistent market data selector naming * feat: view layer changes to support multi currency display * feat: add currency selection to settings modal * chore: add multi currency feature flag * feat: balance chart changes * chore: delete duplicate test with wrong file extension * chore: cache fee asset selector * Revert "chore: cache fee asset selector" This reverts commit dfcd3d0. * fix: revert chart loading behaviour * fix: default fiatType to USD * test: fix useLocaleFormatter test * chore: delete unnecessary locale renderers * chore: revert unnecessary changes to locale formatter * fix: improved number formatting * feat: currency format settings * fix: test case fixed * fix: improved input parsing * chore: fix typo * feat: walletconnect wallet (#1733) * feat: init walletconnect integration * chore: lint * fix: wallet init * fix: wallet init * fix: add imagedelivery to headers * chore: use package version * chore: show/hide WalletConnect based on flag * fix: headers for macos/ios safari * fix: show feature flag nav item for alt host * perf: add env var for better local development * chore: remove unecessary code * chore: remove package dep * chore: add hdwallet-walletconnect alpha dependency * fix: add walletconnect csp entries * fix: utilize feature flag * fix: add mobileEnabled field to WalletConnect config * chore: run linter * fix: remove usage of process.env * chore: run linter * fix: apply code review suggestions * fix: use structured logging * fix: apply code review suggestions * fix: update csp for wallet logos * chore: add flag to sample.env * chore: yarn.lock * docs: fleek info * fix: img source csp * chore: revert readme to develop * fix: image fetched by walletconnect * feat: WalletConnect rejection * chore: lint * chore: lint * chore: update hdwallet-walletconnect dependency * chore: upgrade hdwallet-walletconnect * fix: set wc connect modal error to null on init * chore: run linter * fix: walletconnect refresh bug * chore: upgrade hdwallet dependency * chore: bump hdwallet dependencies * fix: csp for walletconnect desktop logos * chore: bump hdwallet package versions * fix: disable trade max with walletconnect * fix: disable sendmax with walletconnect * chore: run linter * chore: update hdwallet dependencies * chore: run linter * fix: hide fiat sendMax with WalletConnect * fix: stylistic changes * fix: typo * feat: add copy to walletconnect option in selectmodal * fix: constrain icon width for selectmodal options * fix: update return value Co-authored-by: pastaghost <[email protected]> Co-authored-by: 0xdef1cafe <[email protected]> * chore(deps): bump terser from 4.8.0 to 4.8.1 (#2197) Bumps [terser](https://github.com/terser/terser) from 4.8.0 to 4.8.1. - [Release notes](https://github.com/terser/terser/releases) - [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md) - [Commits](https://github.com/terser/terser/commits) --- updated-dependencies: - dependency-name: terser dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: dogecoin (#2185) * feat: dogecoin initial * add dogecoin * use p2pkh accountType for dgubs add dogecoin else if to handleSend :( add dogecoin case to handleSendMax :( :( * wrap doge plugin in a feature flag * pass chainId to utxoAccountParams * remove reference to dogecoin testnet * web clean up * fix: update old utility to new caip method * chore: add REACT_APP_FEATURE_DOGECOIN=true to sample.env * fix: update swapper logic to pass correct param * chore: version bump doge libs * fix: add dogecoin label to accounts page * fix: don't show tokens under dogecoin account Co-authored-by: 0xdef1cafe <[email protected]> Co-authored-by: Apotheosis <[email protected]> * fix: typo and lodash import * fix: conflict resolved * feat: keeping order of fiat currencies and currency formats * fix: applying suggested changes Co-authored-by: stackedQ <[email protected]> Co-authored-by: Grant Steuart <[email protected]> Co-authored-by: pastaghost <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Adam Samere <[email protected]> Co-authored-by: Apotheosis <[email protected]> Co-authored-by: reallybeard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for Bitcoin clone Dogecoin
Notice
Pull Request Type
Issue (if applicable)
Risk
Testing
Screenshots (if applicable)
https://live.blockcypher.com/doge/tx/719bf2901fdc4a3f2c57c9f7e10e0dfef9c684a154ac0c295c961984af753dee/