Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: osmosis multi-account swaps #3901

Merged
merged 20 commits into from
Feb 24, 2023

Conversation

pastaghost
Copy link
Collaborator

@pastaghost pastaghost commented Feb 23, 2023

Description

Notice

  • Have you followed the guidelines in our Contributing guide?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #

Risk

Low risk of swapper regressions

Testing

Engineering

Operations

  • From the Cosmos asset page, set up a swap from ATOM on account 0 to OSMO on account 0.
  • Verify that the swap is successful.
  • From the Cosmos asset page, set up a swap from ATOM on account 0 to OSMO on any account other than 0.
  • Verify that the swap is successful

Screenshots (if applicable)

Screenshot 2023-02-23 at 12 39 18 AM

@pastaghost pastaghost requested a review from a team as a code owner February 23, 2023 11:35
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-stamp - tested with a combination of accounts 0, 1+ both on the ATOM and Osmosis side, LGTM.
Will require shapeshift/lib#1211 to be merged and bumped here, as it fixes swaps for buy assets on account 1+, but currently rugs those on account 0

@gomesalexandre gomesalexandre enabled auto-merge (squash) February 24, 2023 05:24
@gomesalexandre gomesalexandre merged commit 3a3d265 into develop Feb 24, 2023
@gomesalexandre gomesalexandre deleted the fix-osmosis-cross-account-swaps branch February 24, 2023 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants