Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: idle opportunities DeFi modal title #3911

Merged
merged 2 commits into from
Feb 24, 2023
Merged

feat: idle opportunities DeFi modal title #3911

merged 2 commits into from
Feb 24, 2023

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Feb 24, 2023 •
edited
Loading

Description

Uses actually legible headers for Idle opportunity modals

Notice

  • Have you followed the guidelines in our Contributing guide?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

N/A

Risk

None?

Testing

  • Idle opportunity headers at Deposit, Withdraw and Claim steps look legible

Engineering

Operations

Screenshots (if applicable)

Prod

Screenshot 2023-02-24 at 10 42 11

Screenshot 2023-02-24 at 10 41 55

Screenshot 2023-02-24 at 10 41 48

This diff

Screenshot 2023-02-24 at 10 38 59

Screenshot 2023-02-24 at 10 38 51

Screenshot 2023-02-24 at 10 38 43

@gomesalexandre Graphite App
Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@gomesalexandre gomesalexandre changed the title fix: idle opportunities DeFi modal title feat: idle opportunities DeFi modal title Feb 24, 2023
@gomesalexandre gomesalexandre marked this pull request as ready for review February 24, 2023 17:56
@gomesalexandre gomesalexandre requested a review from a team as a code owner February 24, 2023 17:56
@0xdef1cafe 0xdef1cafe enabled auto-merge (squash) February 24, 2023 20:00
@0xdef1cafe 0xdef1cafe merged commit 1389e82 into develop Feb 24, 2023
@0xdef1cafe 0xdef1cafe deleted the fix_idle_defi_modal_title branch February 24, 2023 20:06
@0xdef1cafe 0xdef1cafe mentioned this pull request Feb 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xdef1cafe 0xdef1cafe 0xdef1cafe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gomesalexandre @0xdef1cafe