Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unrug pairing for keepkey devices with firmware version < 7.7.0 #3913

Merged
merged 1 commit into from
Feb 24, 2023
Merged

fix: unrug pairing for keepkey devices with firmware version < 7.7.0 #3913

merged 1 commit into from
Feb 24, 2023

Conversation

pastaghost
Copy link
Collaborator

@pastaghost pastaghost commented Feb 24, 2023 •
edited
Loading

Description

  • bumps hdwallet package versions to 1.44.0
  • this will disable Osmosis support for KeepKey devices with installed firmware < 7.7.0 and enable Osmosis support for devices with installed firmware >= 7.7.0.

Notice

  • Have you followed the guidelines in our Contributing guide?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #

Risk

none

Testing

Engineering

Operations

  • Verify that the dashboard loads for KeepKey devices with installed firmware version < 7.7.0
  • Verify that the dashboard loads for KeepKey devices with installed firmware version >= 7.7.0
  • Verify that Osmosis sends are functional for KeepKey devices with installed firmware version >=7.7.0

Screenshots (if applicable)

@pastaghost pastaghost requested a review from a team as a code owner February 24, 2023 21:25
@pastaghost pastaghost changed the title fix: hdwallet-keepkey version check chore: bump hdwallet packages Feb 24, 2023
gomesalexandre
gomesalexandre approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with a KK with the latest stable firmware, confirmed this does what it says on the box and unrugs KK pairing:

image

@pastaghost pastaghost changed the title chore: bump hdwallet packages fix: unrug pairing for keepkey devices with firmware version < 7.7.0 Feb 24, 2023
@gomesalexandre gomesalexandre merged commit 588b4cf into develop Feb 24, 2023
@gomesalexandre gomesalexandre deleted the fix-hdwallet-kk-version-check branch February 24, 2023 21:51
@0xdef1cafe 0xdef1cafe mentioned this pull request Feb 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gomesalexandre gomesalexandre gomesalexandre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pastaghost @gomesalexandre