Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keepkey swaps from RUNE #4186

Merged
merged 2 commits into from
Apr 4, 2023
Merged

fix: keepkey swaps from RUNE #4186

merged 2 commits into from
Apr 4, 2023

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Apr 4, 2023

Description

Bumps chain-adapters to latest, see shapeshift/lib#1231 for more info on what this does and why.

tl;dr uses a MsgDeposit message that hdwallet-keepkey accepts and won't throw, and that can be signed by the KeepKey firmware, making swaps from RUNE on KeepKey great (unfortunately not again).

Notice

  • Have you followed the guidelines in our Contributing guide?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

N/A

Risk

None, can't break what's already broken

Testing

  • Connect a KeepKey

  • Ensure THORChain swaps from RUNE are working

  • As a sanity check, ensure swaps to RUNE are also working, though the lib PR doesn't actually touch this

  • Expected/min. amounts aren't a concern of this PR

Engineering

  • ☝🏽

Operations

  • ☝🏽

Screenshots (if applicable)

image

image

image

image

image

Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@gomesalexandre gomesalexandre marked this pull request as ready for review April 4, 2023 14:26
@gomesalexandre gomesalexandre requested a review from a team as a code owner April 4, 2023 14:26
@0xdef1cafe 0xdef1cafe enabled auto-merge (squash) April 4, 2023 15:07
@0xdef1cafe 0xdef1cafe merged commit 44bd3f0 into develop Apr 4, 2023
@0xdef1cafe 0xdef1cafe deleted the fix_swaps_from_rune branch April 4, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants