SHARD-1708: Add network account listOfChanges update script #126
Conversation
…ling in GlobalAccount
S0naliThakur
requested review from
aniketdivekar,
urnotsam,
jintukumardas and
afostr
| } | ||
|
|
||
| // Utility function to validate and parse input based on expected type | ||
| const parseInput = (value: string, expectedType: string, defaultValue: any): any => { |
There was a problem hiding this comment.
I am not sure how I feel about assigning a defaultValue. If we're using this code to overwrite the network account, I somewhat feel that there should only be intentional and explicit changes.
There was a problem hiding this comment.
Clarifying... the question is should we treat the results differently if we ended up with value or defaultValue?
There was a problem hiding this comment.
The default values are there to make it quicker and easier to input values from the terminal. Users are always asked what they want to use as input, so the default values get replaced with whatever they enter. Of course, you can also tweak the inputs directly in the script if you wish. The parameters are completely flexible and can be changed as needed.
Right now, we’re keeping it simple by starting with just baselineNodes, minNodes, and maxNodes
| console.log('❌ Changes were not applied.') | ||
| } | ||
|
|
||
| await dbstore.closeDatabase() |
There was a problem hiding this comment.
Should we have a try/finally setup here to ensure DB closure?
| const expectedType = typeof defaultConfig[section][key] | ||
| const parsedValue = parseInput(value, expectedType, defaultConfig[section][key]) | ||
|
|
||
| if (parsedValue !== defaultConfig[section][key] || value === '') { |
There was a problem hiding this comment.
parsedValue == defaultConfig[section][key] this can be a genuine case right? I mean not an error. We can suppress this error or simply say you have not updated the value.
Also what's the purpose of value === '' condition?
There was a problem hiding this comment.
The value === '' condition is checking for when the user just hits enter without typing anything, indicating they want to accept the default value.
| let cycleNumberInput: number | ||
| do { | ||
| cycleNumberInput = parseInt( | ||
| await askQuestion('Enter cycle number (must be less than the latest cycle number, latest cycle number is: ' + latestCycleNumber + '): '), |
There was a problem hiding this comment.
why this has to be lesser and greater? won't the change be applied in future cycles?
There was a problem hiding this comment.
This is implemented as per the ticket specification
…ount update script
Linear: https://linear.app/shm/issue/SHARD-1708
Summary: Add network account listOfChanges update script