Revert "Remove unnecessary node lists in NodeList module to improve performance" #23
Conversation
|
Issue reopened: BLUE-56 Refactor maintaining nodelist in the archivers. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -129,16 +135,18 @@ | |||
| break | |||
| } | |||
| /* eslint-disable security/detect-object-injection */ | |||
| byPublicKey.set(node.publicKey, node) | |||
| byPublicKey[node.publicKey] = node | |||
Check failure
Code scanning / CodeQL
Remote property injection High
| if (entry) { | ||
| entry.id = node.id | ||
| byId.set(node.id, node.publicKey) | ||
| publicKeyToId[node.publicKey] = node.id |
Check failure
Code scanning / CodeQL
Remote property injection High
| if (entry) { | ||
| entry.id = node.id | ||
| byId.set(node.id, node.publicKey) | ||
| publicKeyToId[node.publicKey] = node.id | ||
| byId[node.id] = node |
Check failure
Code scanning / CodeQL
Remote property injection High
| @@ -166,16 +176,18 @@ | |||
| break | |||
| } | |||
|
|
|||
| byPublicKey.set(node.publicKey, node) | |||
| byPublicKey[node.publicKey] = node | |||
Check failure
Code scanning / CodeQL
Remote property injection High
| if (entry) { | ||
| entry.id = node.id | ||
| byId.set(node.id, node.publicKey) | ||
| publicKeyToId[node.publicKey] = node.id |
Check failure
Code scanning / CodeQL
Remote property injection High
| if (entry) { | ||
| entry.id = node.id | ||
| byId.set(node.id, node.publicKey) | ||
| publicKeyToId[node.publicKey] = node.id | ||
| byId[node.id] = node |
Check failure
Code scanning / CodeQL
Remote property injection High
| delete byPublicKey[key] | ||
| const id = publicKeyToId[key] | ||
| activeListByIdSorted = activeListByIdSorted.filter((node) => node.id !== id) | ||
| delete byId[id] |
Check failure
Code scanning / CodeQL
Remote property injection High
Reverts #16