Refactor API router #1294
Merged
Refactor API router #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpuputti
force-pushed
the
refactor-api-router
branch
from
245168e to
bbcd9f1
Compare
kpuputti
force-pushed
the
refactor-api-router
branch
from
bbcd9f1 to
6c72976
Compare
OtterleyW
approved these changes
May 19, 2020
There was a problem hiding this comment.
LGTM
I'm not sure if the doc about enabling the login as feature should be updated
|
@OtterleyW Ah, great point about the docs. I'll check that before merging this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the server API router. Each endpoint is now a separate file, and the router file just connects the paths to the route handlers.
This opens up possibilities for deployment and for endpoints that can be run along the development server.
TODO