Add password reset link #1367
Merged
Add password reset link #1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OtterleyW
force-pushed
the
add-facebook-login
branch
from
6f7d350 to
8cd84e0
Compare
OtterleyW
force-pushed
the
add-passowrd-reset-link
branch
from
787087d to
8e9d5fc
Compare
OtterleyW
force-pushed
the
add-passowrd-reset-link
branch
from
8e9d5fc to
cc0b0b3
Compare
lyyder
reviewed
Oct 13, 2020
Comment on lines
15
to
17
| export const RESET_PASSWORD_REQUEST = 'app/PasswordResetPage/RESET_PASSWORD_REQUEST'; | ||
| export const RESET_PASSWORD_SUCCESS = 'app/PasswordResetPage/RESET_PASSWORD_SUCCESS'; | ||
| export const RESET_PASSWORD_ERROR = 'app/PasswordResetPage/RESET_PASSWORD_ERROR'; |
There was a problem hiding this comment.
Would it make sense to import these from PasswordResetPage duck? Do we have a pattern for using other page's states in another duck?
There was a problem hiding this comment.
I assume this is a copy-paste typo. Rename this action strings correctly or our page-reducers start to react other pages changes. (One option is to create public duck-file, but that might be an overkill.
There was a problem hiding this comment.
Yeah, that's a copy-paste typo (it seems I never remember to change them...) I'll fix that!
I also considered a shared duck file for these but it really felt a bit overkill for now.
OtterleyW
force-pushed
the
add-passowrd-reset-link
branch
from
cc0b0b3 to
0b92d55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.