Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PriceFilter popup not close when click outside on Safari #1452

Conversation

chanthientukk9
Copy link
Contributor

@chanthientukk9 chanthientukk9 commented Jul 7, 2021

This PR is used to:

  • Fix PriceFilter popup not close when click outside on Safari. It happens because onBlur of <div> tag not working on Safari.

@Gnito
Copy link
Contributor

Gnito commented Aug 2, 2021

Hi, and sorry - we haven't followed PRs during summer time :(

It does make sense to use OutsideClickHandler in here. It's a bit newer component than PriceFilter itself - so, we have just not remembered to change it at the time. (Actually, PriceFilter should get some extra attention at some point - there just always seem to be something else in the pipeline.)

Anyway, I'll get back to this hopefully at some point this week, but at least one change should be made: The comment inside handleBlur should be removed since it's not relevant after the change.)

@Gnito
Copy link
Contributor

Gnito commented Aug 3, 2021

Closing this in favour of #1455

@Gnito Gnito closed this Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants