-
Notifications
You must be signed in to change notification settings - Fork 938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #1483
Update dependencies #1483
Conversation
Couple of comments:
I didn't mention yesterday, but loadable components are also tied with our CRA fork - so, if sharetribe-scripts is not updated at the same time, then some SSR testing is needed to verify that client app versions of those libs are working with the version of loadable stuff we have on sharetribe-scripts. |
@Gnito Good points about Prettier. That just introduces conflicts with no real benefits. And customizers can easily update the lib and format if they really want that (although that might introduce conflicts in any case). I did check to match |
03f4738
to
6ce92dd
Compare
cookie-parser, path-to-regexp, query-string
These are pinned down to the same versions required in sharetribe-scripts.
c86642f
to
c74a423
Compare
Now the Prettier and Loadable updates have been removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Note: it might make sense to review the other PR first before merging this to master. Mainly, because, that feature branch is deployed to staging atm.
Update several dependencies. See changes to
package.json
for full info.