-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2783 setting terminal title #2807
Merged
sharkdp
merged 33 commits into
sharkdp:master
from
Oliver-Looney:2783-setting-terminal-title
Feb 23, 2024
Merged
Changes from 13 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
2e103ee
able to set terminal title to hardcoded value
Oliver-Looney 4863d42
title is being reset on quit, so no need to restore terminal title
Oliver-Looney b9b5542
successfully setting the terminal title to bat's input's names
Oliver-Looney 069318b
fixed formatting of terminal title
Oliver-Looney 6ad800e
tidied commits
Oliver-Looney fd84e4f
fixed all but two failing tests. Last two tests are erroring because …
Oliver-Looney 12b74df
terminal title is only set when pager is being used
Oliver-Looney 907af9e
updated tests since terminal title is set conditionally
Oliver-Looney 1679460
updated CHANGELOG.md
Oliver-Looney 321b3ec
updated CHANGELOG.md
Oliver-Looney 0027055
fixed system_wide_config.rs tests
Oliver-Looney 5b4ce68
ran cargo fmt
Oliver-Looney d7503bf
Merge branch 'master' into 2783-setting-terminal-title
Oliver-Looney 57016f4
small refactoring of set terminal title function
Oliver-Looney 3b0ade9
slightly changed set terminal command to match docs & broke print lin…
Oliver-Looney 6f1cc80
Merge branch 'master' into 2783-setting-terminal-title
Oliver-Looney c261b41
trying to fix failing system_wide_config.rs tests
Oliver-Looney b4fdb5d
Merge branch 'master' into 2783-setting-terminal-title
Oliver-Looney 9239b12
added a flag to config for setting terminal title
Oliver-Looney b33e33f
terminal title is only set if user opts in with --set_terminal_title …
Oliver-Looney c911829
fixed failing tests
Oliver-Looney f6d76e0
added integration test for setting terminal title
Oliver-Looney 2225493
ran cargo fmt
Oliver-Looney 9be2a36
fixed system wide config tests failing
Oliver-Looney e9a6aaa
cargo fmt
Oliver-Looney 60e32cf
removed set_terminal_title arg from clap_app.rs since other boolean a…
Oliver-Looney 7f12989
added set_terminal_title arg to clap_app.rs to fix ci errors
Oliver-Looney a8d0733
updated integration_tests.rs
Oliver-Looney 7ce010d
Using hypens instead of underscores for set-terminal-title command
Oliver-Looney 02077db
undid unnecessary api visibility changes
Oliver-Looney 8a51172
simplified basic_set_terminal_title
Oliver-Looney c3f2ddf
Merge branch 'master' into 2783-setting-terminal-title
Oliver-Looney 1f62820
Merge branch 'master' into 2783-setting-terminal-title
Oliver-Looney File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this behave well in all major terminal emulators on all major OSes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe ANSI escape characters are standard across terminal emulators on different OSes, https://en.wikipedia.org/wiki/ANSI_escape_code#OSC_(Operating_System_Command)_sequences
I have updated the
2
in this line to0
to match those docs