Allow passing length in hex with 0x notation #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Definitely related to #44. :) |
|
@Qyriad Thank you very much for your contribution! We will need to bump the minimum required Rust version (in |
sharkdp
reviewed
Jan 26, 2019
src/main.rs
Outdated
| @@ -258,7 +258,14 @@ fn run() -> Result<(), Box<::std::error::Error>> { | |||
|
|
|||
| if let Some(length) = matches | |||
| .value_of("length") | |||
| .and_then(|n| n.parse::<u64>().ok()) | |||
| .and_then(|n| { | |||
| if n.starts_with("0x") { | |||
There was a problem hiding this comment.
We should probably also adapt the help-text to make users aware of this possibility.
|
Pinging @Qyriad to see if they're still able to attend to this. |
|
Oh right; yeah I can do this in the next day or two. |
|
Sorry, I've missed your update. Could you please rebase this on |
|
Done. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This interprets a
0xin front of the value passed with--length/-nas a hexadecimal number.