Skip to content

Commit

Permalink
Don't set crossterms underline color/ Fix blink
Browse files Browse the repository at this point in the history
We were observing blinking as an artifact for colored output in several
terminal emulators (e.g. Windows Terminal, Mac's Terminal.app)

nushell/nushell#6172 (comment)

To resolve that, don't specifically set the underline color as it is
optional.
  • Loading branch information
sholderbach authored and sharkdp committed Aug 2, 2022
1 parent d4a5226 commit 74ec36a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/style.rs
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ impl Style {
foreground_color: self.foreground.as_ref().map(Color::to_crossterm_color),
background_color: self.background.as_ref().map(Color::to_crossterm_color),
attributes: self.font_style.to_crossterm_attributes(),
underline_color: self.foreground.as_ref().map(Color::to_crossterm_color),
underline_color: None,
}
}
}
Expand Down

0 comments on commit 74ec36a

Please sign in to comment.