Improve unterminated string interpolation error #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, the error span would point to the whole string:
>>> {x} {1"
error: while parsing
┌─ <input:16>:1:1
│
1 │ "{x} {1"
│ ^^^^^^^^ Unterminated {...} interpolation in this string
Now it only points to the unfinished interpolation:
>>> "{x} {1"
error: while parsing
┌─ <input:2>:1:6
│
1 │ "{x} {1"
│ ^^ Unterminated string interpolation
sharkdp
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the error span would point to the whole string:
Now it only points to the unfinished interpolation:
How do you think I should go about adding a test for this, or is it not needed?