Use local timezone, not local UTC offset #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, we treat "local" as the local timezone, whereas
before, we treated "local" as the local (current) UTC offset.
The following behavior is shown for timezone Europe/Berlin, during
winter.
Before: UTC offset is used for parse_datetime
>>> parse_datetime("2024-01-01T12:00:00Z")
= Mon, 1 Jan 2024 12:00:00 +0000 [DateTime]
After:
>>> parse_datetime("2024-01-01T12:00:00Z")
= Mon, 1 Jan 2024 13:00:00 +0100 [DateTime]
Before: "Winter" UTC offset is used for datetime in summer
>>> parse_datetime("2024-07-01T12:00:00Z") -> "local"
= Mon, 1 Jul 2024 13:00:00 +0100 [DateTime]
After: "Summer" UTC offset is used for datetime in summer
>>> parse_datetime("2024-07-01T12:00:00Z") -> "local"
= Mon, 1 Jul 2024 14:00:00 +0200 [DateTime]
After: "Winter" UTC offset is used for datetime in winter
>>> parse_datetime("2024-01-01T12:00:00Z") -> "local"
= Mon, 1 Jan 2024 13:00:00 +0100 [DateTime]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, we treat "local" as the local timezone, whereas before, we treated "local" as the local (current) UTC offset.
The following behavior is shown for timezone Europe/Berlin, during winter.
Before: UTC offset is used for parse_datetime
After:
Before: "Winter" UTC offset is used for datetime in summer
After: "Summer" UTC offset is used for datetime in summer
After: "Winter" UTC offset is used for datetime in winter