Fix/#45 good ch refactor (issue on remote repo) #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* change signal signature
* add missing pyqtSlot decorators * coda readability improvements
* preserves original chanMap, which is overwritten during preprocess * use chanMapBackup to generate default good_channels arrays * remove risky usages of chanMap
* correctly account for good channels and determine channels to be displayed
* change signal signature
* add missing pyqtSlot decorators * coda readability improvements
* preserves original chanMap, which is overwritten during preprocess * use chanMapBackup to generate default good_channels arrays * remove risky usages of chanMap
* correctly account for good channels and determine channels to be displayed
…tsridhar/pykilosort into fix/#45_good_ch_refactor � Conflicts: � pykilosort/gui/data_view_box.py � pykilosort/gui/probe_view_box.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major refactor that moves the processing of good channels out of the data loading step. Good channels are now calculated during the preprocessing step. This speeds up data load tremendously.