Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

randomisations - clear more rand_structured bottlenecks #685

Closed
shawnlaffan opened this issue Feb 24, 2018 · 1 comment
Closed

randomisations - clear more rand_structured bottlenecks #685

shawnlaffan opened this issue Feb 24, 2018 · 1 comment
Assignees
@shawnlaffan
Labels
enhancement randomisations
Milestone
Release_2.1

Comments

@shawnlaffan
Copy link
Owner

profiling shows some bottlenecks in Biodiverse::Randomise::rand_structured. These need to be opened up.
@shawnlaffan shawnlaffan added this to the Release_2.1 milestone Feb 24, 2018
@shawnlaffan shawnlaffan self-assigned this Feb 24, 2018
shawnlaffan added a commit that referenced this issue Feb 24, 2018
@shawnlaffan
Use unfilled groups directly rather than rebuilding it each time
4dd6783 
We were setting the target groups to the full possible set and
then trimming out the filled groups.  It makes more sense to
use the unfilled groups, since we are tracking them anyway.

updates #685
shawnlaffan added a commit that referenced this issue Feb 24, 2018
@shawnlaffan
Use a sorted array to avoid repeated sorting
10b64ff 
Updates #685
shawnlaffan added a commit that referenced this issue Feb 24, 2018
@shawnlaffan
remove some old debugging code
26d03a7 
Gives a slightly shorter and neater sub.

Updates #685
shawnlaffan added a commit that referenced this issue Feb 24, 2018
@shawnlaffan
Avoid the need for a copied hash
a3d9d5b 
It was only used to check deletions, so we can build one as we go instead.
Copying the original hash was a substantial part of the run time under profiling.

Also clear up some commentary.

Updates #685
shawnlaffan added a commit that referenced this issue Feb 24, 2018
@shawnlaffan
mark known bottleneck with a comment
1d6b62a 
Updates #685
@shawnlaffan
Copy link
Owner Author

Mark as fixed.

The remaining known bottleneck can be handled in its own issue later.

@shawnlaffan shawnlaffan mentioned this issue Aug 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawnlaffan shawnlaffan

Labels
enhancement randomisations
Projects
None yet
Milestone
Release_2.1
Development

No branches or pull requests
1 participant
@shawnlaffan