Address reviewer's feedback

shawnxie999 · Oct 22, 2024 · 9d84f3b · 9d84f3b
1 parent 0905e37
commit 9d84f3b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/xrpld/ledger/View.h b/src/xrpld/ledger/View.h
@@ -524,7 +524,7 @@ transferXRP(
     STAmount const& amount,
     beast::Journal j);
 
-/** Check if the account requires authorization.
+/** Check if the account lacks required authorization.
  *   Return tecNO_AUTH or tecNO_LINE if it does
  *   and tesSUCCESS otherwise.
  */

diff --git a/src/xrpld/ledger/detail/View.cpp b/src/xrpld/ledger/detail/View.cpp
@@ -1989,11 +1989,16 @@ rippleCredit(
     return std::visit(
         [&]<ValidIssueType TIss>(TIss const& issue) {
             if constexpr (std::is_same_v<TIss, Issue>)
+            {
                 return rippleCreditIOU(
                     view, uSenderID, uReceiverID, saAmount, bCheckIssuer, j);
+            }
             else
+            {
+                assert(!bCheckIssuer);
                 return rippleCreditMPT(
                     view, uSenderID, uReceiverID, saAmount, j);
+            }
         },
         saAmount.asset().value());
 }