Use vscode watches for tsserver #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -268,6 +268,7 @@ export class TypeScriptServerSpawner { | |||
| args.push('--locale', TypeScriptServerSpawner.getTsLocale(configuration)); | |||
|
|
|||
| args.push('--noGetErrOnBackgroundUpdate'); | |||
| args.push('--canUseWatchEvents'); // TODO check ts version | |||
There was a problem hiding this comment.
I think this is just
Suggested change
| args.push('--canUseWatchEvents'); // TODO check ts version | |
| if (apiVersion.gte(API.v520)) { | |
| args.push('--canUseWatchEvents'); | |
| } |
Since versions made using fromVersionString throw away pre-releases tags.
sheetalkamat
force-pushed
the
canUseWatchEvents
branch
from
b565a6c to
dc7891d
Compare
add setting info to terminal help dialog
Open
get text area sync addon to work for terminals in the editor area
…block align next/previous codeblock keybindings w those of notebook output editors
…ings align acceptance keybindings
* Add notes on chat agent API * Add request ID to context * variables * Add partial implementation for another option for a chat agent API * update * Notes from api sync * More notes * Can invoke an agent and get the response * Provide a real request * Notes * add `slashCommandProvider` - not yet hooked up * add metadata properties inline, some comments * some more notes * Put the new API side-by-side with the old one * Fix agent title in response * Fix agent display * Send slashCommand to request * Hook up variables * Get rid of package.json registration option * Start to implement followups provider * Add comment * make it `slashCommandProvider` all the way, use updateAgent for updates icon, fullName, description * update docs * only ask for slash command completions when completing a slash-word * use complex completion item label for command/agent completions * add `promptText` to `IParsedChatRequestPart` so that some parts don't make it into the prompt (like agent and slash commands) * only allow agent and slash command at the beginning of the prompt * remove unused method * some jsdoc, many renames so that stuff starts with `ChatAgent...` * reduce `createChatAgent` to the minimum, let the rest be set via setters * in the renderer know if an agent has slash command and follow ups, safes IPC calls * use `iconPath` to align with other APIs * more jsdoc and more obvious TODOs * fix chat parser with "late" command * handle error so that the request stops. where is the rendering tho? * Show error message in response properly * Don't blow up global / list * Change proposal name * Inline followup types * fix type * Remove brace in error msg --------- Co-authored-by: Johannes <[email protected]>
|
Closing for microsoft#193848 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works with microsoft/TypeScript#54662