Update 22.1.x #29
Merged
Update 22.1.x #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Jts upgrade 21.2 (#19) * Additional Functionality (#13) * Added intersection and collection support * ST_Collect and ST_CollectAggregate now work alongside each other * Added additional ST* functionality * Minor name fixes * Improved collection ser/de performance * Import fixes * Readme fixes * Readme fixes * Additional Functionality (#13) (#14) * Added intersection and collection support * ST_Collect and ST_CollectAggregate now work alongside each other * Added additional ST* functionality * Minor name fixes * Improved collection ser/de performance * Import fixes * Readme fixes * Readme fixes * Work on angle functionality and proj4 transform * Added missing files * Added ST_Angle implementations * Added Azimuth * Added ST_Union Aggregate variant * Some fixes following manual tests * Jts upgrade 21.1 (#18) * Additional Functionality (#13) * Added intersection and collection support * ST_Collect and ST_CollectAggregate now work alongside each other * Added additional ST* functionality * Minor name fixes * Improved collection ser/de performance * Import fixes * Readme fixes * Readme fixes * Work on angle functionality and proj4 transform * Added missing files * Added ST_Angle implementations * Added Azimuth * Added ST_Union Aggregate variant * Some fixes following manual tests * Bad version fix * 21.1.x add tests (#20) * Dremio 21.2.x upgrade * Updated WIKI link * Additional Functionality (#13) * Added intersection and collection support * ST_Collect and ST_CollectAggregate now work alongside each other * Added additional ST* functionality * Minor name fixes * Improved collection ser/de performance * Import fixes * Readme fixes * Readme fixes * Additional Functionality (#13) (#15) * Added intersection and collection support * ST_Collect and ST_CollectAggregate now work alongside each other * Added additional ST* functionality * Minor name fixes * Improved collection ser/de performance * Import fixes * Readme fixes * Readme fixes * Work on angle functionality and proj4 transform * Added missing files * Added ST_Angle implementations * Added Azimuth * Added ST_Union Aggregate variant * Some fixes following manual tests * Readme Update * version bump, updated readme * ST_X tests foundations laid down * Checkstyle IDEA * Made improvement with test coverage * A lot more work on tests Better code formatting * Some more relation tests cleanup * Added detekt style checks and fixed CI * Missing detekt plugin configuration * Added output tests * Add Geometry Input Tests * Add Geometry input testing * Added WKB Input tests * Measurement functions testing * Added overlay function tests * Some more overlay function tests * Added codecov * Added GH hosted runners * Coverall migration * Coverall migration * Coverall migration * Coverall migration * Coverall migration * Added some more tests * Added some ST_Transform test functionality * Additional transformation tests * Somme additional transformation tests * Print evaluated geom * Done scaling geometry values * Done scaling geometry values * Improve collection coverage * Remove printing * Added ST_Buffer tests and new variant * Removed new buffer variant * Added coveralls badge Co-authored-by: Idan Sheinberg <[email protected]> * Add tests 21.2.x (#21) * Updated WIKI link * Additional Functionality (#13) * Added intersection and collection support * ST_Collect and ST_CollectAggregate now work alongside each other * Added additional ST* functionality * Minor name fixes * Improved collection ser/de performance * Import fixes * Readme fixes * Readme fixes * Additional Functionality (#13) (#14) * Added intersection and collection support * ST_Collect and ST_CollectAggregate now work alongside each other * Added additional ST* functionality * Minor name fixes * Improved collection ser/de performance * Import fixes * Readme fixes * Readme fixes * Work on angle functionality and proj4 transform * Added missing files * Added ST_Angle implementations * Added Azimuth * Added ST_Union Aggregate variant * Some fixes following manual tests * Jts upgrade 21.1 (#18) * Additional Functionality (#13) * Added intersection and collection support * ST_Collect and ST_CollectAggregate now work alongside each other * Added additional ST* functionality * Minor name fixes * Improved collection ser/de performance * Import fixes * Readme fixes * Readme fixes * Work on angle functionality and proj4 transform * Added missing files * Added ST_Angle implementations * Added Azimuth * Added ST_Union Aggregate variant * Some fixes following manual tests * Bad version fix * Readme Update * version bump, updated readme * ST_X tests foundations laid down * Checkstyle IDEA * Made improvement with test coverage * A lot more work on tests Better code formatting * Some more relation tests cleanup * Added detekt style checks and fixed CI * Missing detekt plugin configuration * Added output tests * Add Geometry Input Tests * Add Geometry input testing * Added WKB Input tests * Measurement functions testing * Added overlay function tests * Some more overlay function tests * Added codecov * Added GH hosted runners * Coverall migration * Coverall migration * Coverall migration * Coverall migration * Coverall migration * Added some more tests * Added some ST_Transform test functionality * Additional transformation tests * Somme additional transformation tests * Print evaluated geom * Done scaling geometry values * Done scaling geometry values * Improve collection coverage * Remove printing * Added ST_Buffer tests and new variant * Removed new buffer variant * Added coveralls badge Co-authored-by: Idan Sheinberg <[email protected]> * Done with aggregate testing * Done with aggregate testing * Formatting fixes * Dremio compat fixes * Lot's of work on buffer parsing * Code now compiles * Added ST_Buffer tests * Added ST_Buffer tests * Added ST_Buffer tests * Coverage targets * Version alignment * Version alignment * Readme fix Co-authored-by: Idan Sheinberg <[email protected]>
checkstyle lower requirements Kotest/kotlin upgrades Added ST_GeometryN, ST_GeomFromEWKT and ST_NumGeometries support
Detekt upgrade
# Conflicts: # .idea/kotlinc.xml # pom.xml # src/main/java/org/sheinbergon/dremio/udf/gis/util/GeometryHelpers.java
Fixed ST_Envelope Moved more functions to use internal null handling
More functions moved to internal null handling
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| @@ -50,6 +52,9 @@ public final class GeometryHelpers { | |||
| private static final int GEOMETRY_DIMENSIONS = 2; | |||
| private static final double AZIMUTH_NORTH_RADIANS = Angle.toRadians(90.0); | |||
|
|
|||
| private static final String EWKT_TEMPLATE = "SRID=%d;%s"; | |||
There was a problem hiding this comment.
InlineFormatString: Prefer to create format strings inline, instead of extracting them to a single-use constant
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.