Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node positional information for files with single-quotes in comments #164

Merged
merged 8 commits into from
Oct 9, 2021
Merged

Fix node positional information for files with single-quotes in comments #164

merged 8 commits into from
Oct 9, 2021

Conversation

nwalters512
Copy link
Contributor

This resolves issue #163.

Please check one:

  • New tests created for this change
  • Tests updated for this change

This PR:

  • Adds new API
  • Extends existing API, backwards-compatible
  • Introduces a breaking change
  • Fixes a bug

This PR is my attempt at resolving the issue described in #163. It makes the new tests I added pass, and it doesn't break any existing tests. Unfortunately, most of the existing tests don't assert anything about positional information, so it's pretty difficult for me to assert that this doesn't adversely impact anything else. I'd be happy to augment some existing tests with positional information to help increase confidence.

The change to lib/nodes/inline-comment.js was necessary to get the following assertion about the end position of a comment to pass:

t.is(innerCommentNode.source.end.column, 6);

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2021

Codecov Report

Merging #164 (83f0986) into master (c92f312) will increase coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
+ Coverage   97.38%   97.56%   +0.17%     
==========================================
  Files           3        3              
  Lines         153      164      +11     
==========================================
+ Hits          149      160      +11     
  Misses          4        4              
Impacted Files Coverage Δ
lib/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c92f312...83f0986. Read the comment docs.

@nwalters512 nwalters512 marked this pull request as ready for review August 10, 2021 22:58
@shellscape shellscape merged commit 4f36de8 into shellscape:master Oct 9, 2021
@shellscape
Copy link
Owner

thanks!

@nwalters512 nwalters512 deleted the fix/invalid-location-with-single-quote-comments branch November 3, 2021 17:21
@nwalters512
Copy link
Contributor Author

@shellscape do you have a rough estimate of when this will be released in a new version on npm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants