fix: setting properties on loop variable from foreach doesn't work

close #129

Makefile

@@ -1,6 +1,6 @@
 version = `cat package.json | grep version | awk -F'"' '{print $$4}'`
 SRC = $(wildcard src/*.js src/**/*.js)
-TESTS = $(wildcard tests/*.js)
+TESTS = $(wildcard test/*.js)
 BIN := ./node_modules/.bin
 REPORTER ?= spec
 

package.json

@@ -31,7 +31,7 @@
     "should": "^7.0.1"
   },
   "scripts": {
-    "test": "mocha tests --require should",
+    "test": "mocha test --require should",
     "pub": "npm version patch && npm publish && git push origin master && git push origin --tag"
   },
   "spm": {

src/compile/set.js

@@ -25,7 +25,8 @@ module.exports = function(Velocity, utils) {
       // @see #25
       if (this.condition && this.condition.indexOf('macro:') === 0) {
         context = this.context;
-      } else {
+        // fix #129
+      } else if (!context.hasOwnProperty(ref.id)) {
         // set var to global context, see #100
         context = this.context;
       }

tests/foreach.test.js → test/foreach.test.js

@@ -139,4 +139,27 @@ describe('Loops', function() {
     const ret = render(vm, context);
     ret.replace(/\s+/g, '').should.equal('matched:"[2]"');
   });
+
+  it('set ok, fix #129', () => {
+    const context = {
+      records: [{ ID: '1' }, { ID: '2' }, { ID: '3' }],
+    };
+
+    const template1 = `
+    #foreach($item in $records)
+        #set( $item.key = $item.ID )
+    #end
+    $records`;
+    const template2 = `
+    #foreach($x in $records)
+        #set( $item = $x )
+        #set( $item.key = $item.ID )
+    #end
+    $records`;
+
+    const ret = render(template1, context);
+    ret.trim().should.equal('[{ID=1, key=1}, {ID=2, key=2}, {ID=3, key=3}]');
+    const ret2 = render(template2, context);
+    ret2.trim().should.equal('[{ID=1, key=1}, {ID=2, key=2}, {ID=3, key=3}]');
+  });
 })