Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.6 #1

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Python 3.6 #1

wants to merge 6 commits into from

Conversation

Carstig
Copy link

@Carstig Carstig commented Sep 20, 2019

Hi, on the search for a pyQt docker image I found your repository. I wanted to step up the python version and found out that install of pyQt5 now works with pip.

I built the image and was able to use it successfully with a different pyQt5 based application (labelImg).

cheers, Carstig.

@shevron
Copy link
Owner

shevron commented Sep 22, 2019

Hi,

This is great! However, I'd like to maintain a (tagged?) version of the Docker image with Python 2.7 and perhaps set up additional Python versions (3.7).

Maintaining 2.7 support is important to me as I still have legacy projects that rely on it.

I'd like to merge your PR but firts need to figure out how to create tagged images in Docker Hub. If you have any experience with that, let me know.

@Carstig
Copy link
Author

Carstig commented Sep 24, 2019

Hi, I totally understand.

Though, it is my first time I pushed a docker image to dockerhub, I think I tagged it following a this guide

I would consider the tag, the part following the colon ':' - in the example firsttry . When you look at the image I created based on this python-3.6 branch (see dockerhub ) then the tag I used was latest

So, in our case, looks like we need to rebuild the image, and then tag it with something like python2.7 and push it to hub.docker.com.

@Carstig
Copy link
Author

Carstig commented Sep 24, 2019

....and another idea. I was just going through my images on hub.docker.com and stumbled over the Automated Builds I was looking then on the example rules and would try to configure a rule for "Tags".

That is what I did for my labelImg container and then went to my local checkout of the repo. did a git tag v1.0.1 -m 'some message followed by a git push --follow-tags . I think this looks much cleaner now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants