Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add japanese translation #108

Merged
merged 2 commits into from
Sep 9, 2018
Merged

Add japanese translation #108

merged 2 commits into from
Sep 9, 2018

Conversation

NHRD
Copy link
Contributor

@NHRD NHRD commented Sep 8, 2018

Description and issue

Hi, I completed translation of json to Japanese.
Please review.

#75

List of significant changes made

  • ja/messages.json added.

@NHRD NHRD mentioned this pull request Sep 8, 2018
Closed
shgysk8zer0
shgysk8zer0 approved these changes Sep 9, 2018
View reviewed changes
Copy link
Owner

@shgysk8zer0 shgysk8zer0 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good. Thanks a lot!

Resolves #75

@shgysk8zer0 shgysk8zer0 merged commit db162c9 into shgysk8zer0:master Sep 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shgysk8zer0 shgysk8zer0 shgysk8zer0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NHRD @shgysk8zer0