Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v1): update peer dependency version range for svelte 5 prerelease #4

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

AdrianGonz97
Copy link
Contributor

📑 Description

We received a report (huntabyte/shadcn-svelte#831 (comment)) where installs with npm are failing as the peer dependency version range requirements aren't being met.

To fix, ^5.0.0-next.1 was added to the version range.

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

Copy link

vercel bot commented Aug 19, 2024

@AdrianGonz97 is attempting to deploy a commit to the Shinichi Okada's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Aug 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-radix-runes-webkit ❌ Failed (Inspect) Aug 19, 2024 4:03pm

@shinokada
Copy link
Owner

Please use next version:

pnpm i -D svelte-radix@next

See https://github.com/shinokada/svelte-radix/blob/svelte-5-runes/package.json#L80

@shinokada shinokada closed this Aug 19, 2024
@huntabyte
Copy link

Hey @shinokada, unfortunately, using @next isn't a solution for us as we need to remain backward compatible. We want both Svelte 4 and 5 users to use the same package until we have shadcn-svelte fully updated to Svelte 5.

You already have 5.0.0 in the current version's package.json, it just needs to be updated to include ^5.0.0-next.1 so NPM doesn't lose its mind, and both Svelte 4 and Svelte 5 users can use this package.

Adding this to the line is just a patch release and doesn't break or change anything and it would be very helpful.

Thank you!

@shinokada shinokada reopened this Aug 20, 2024
@shinokada shinokada merged commit f4bc2a1 into shinokada:main Aug 20, 2024
3 checks passed
@shinokada
Copy link
Owner

v1.1.1 is released. Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants