remove lodash dependency from rtp and common packages #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe this hang is an error in the tests per our previous conversations? |
packages/rtp/src/rtcp/rtpfb/twcc.ts
Outdated
Comment on lines
327
to
328
| range(6, (i) => symbolList.push(getBit(data[0], 2 + i * 2, 2))); | ||
| range(6, (i) => symbolList.push(getBit(data[1], i * 2, 2))); |
There was a problem hiding this comment.
oh whoops sorry, thanks
|
If fix that point, the problem with the test will go away. |
Done |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using the rtp sub package within another project and was looking to reduce dependencies for deployed size and supply chain attack surface area. I found that lodash would be trivial to remove (64kb in bundle).