use noble/curves #358
Merged
use noble/curves #358
+113
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koush
reviewed
Dec 17, 2023
| publicKey: Buffer; | ||
| privateKey: Buffer; | ||
| }): Buffer => { | ||
| const elliptic = new ec("p256"); // aka secp256r1 |
There was a problem hiding this comment.
elliptic is still being used here? seem to have added a dependency rather than replaced.
There was a problem hiding this comment.
that code isn't used anymore, from what I see it looks like it was there to validate elliptic vs noble/curves outputs side by side, but not removed after validation. I've already submitted a pull request to completely remove elliptic.
koush
reviewed
Dec 17, 2023
|
|
||
| import { NamedCurveAlgorithm, NamedCurveAlgorithms } from "./const"; | ||
| import { old_p256PreMasterSecret, p256PreMasterSecret } from "./ec"; |
There was a problem hiding this comment.
I think old_p256PreMasterSecret needs to be removed? not seeing it used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#357