move nonstandard into exports #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…osure and dependencies
|
it's also possible to achieve different behavior (or preserve legacy behavior) by using different entry points for main vs exports. |
|
Another option would be to publish the nonstandard stuff in a totally different package, as @werift/nonstandard. This would eliminate the dependencies altogether at compile time, which may have scripts that run during install. I think the current pull request is the least painful transition though. |
|
looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on previous change. #359
The primary goal is to remove mp4box as an automatically included dependency, which is large, and also pulls in a significant portion of lodash.
This requires module resolution node 16 set in tsconfig when used by typescript. which shouldn't be a problem since this library requires node 16 anyways.
https://stackoverflow.com/a/72275458