Fix race conditions by switching to node webcrypto

[koush]

builds on top of #395

certificate creation is async now, so the setupCertificate method needs to handle double calls correctly.

the main issue that was uncovered is that localDescription is now undefined when ice candidate gathering starts.

The underlying issue is that ice candidate gathering is being started during a setRemoteDescription offer. Werift (the answer peer) has not created an answer or called setLocalDescription at this point. But it has started gathering peers based on the offer side description.

werift-webrtc/packages/webrtc/src/peerConnection.ts

Lines 1000 to 1012 in 18b4194

	const connected = this.iceTransports.find(
	(transport) => transport.state === "connected",
	);
	if (this.remoteIsBundled && connected) {
	// no need to gather ice candidates on an existing bundled connection
	await connected.iceGather.gather();
	} else {
	await Promise.allSettled(
	transports.map((iceTransport) => iceTransport.iceGather.gather()),
	);
	}

I believe this behavior is incorrect. Ice candidate gathering should only ever start during createAnswer and createOffer (or possibly setLocalDescription), as that is the typical spec/implementation. And that is also what is expected by onIceCandidate.

werift-webrtc/packages/webrtc/src/peerConnection.ts

Lines 509 to 513 in 18b4194

	iceTransport.iceGather.onIceCandidate = (candidate) => {
	if (!this.localDescription) return;
	if (this.config.bundlePolicy === "max-bundle" || this.remoteIsBundled) {

[koush]

Another option is to queue the dropped candidates and flush them on setLocalDescription.

[koush]

I've fixed the underlying issue where setRemoteDescription is trigger candidating generation prior to createAnswer.

[koush]

I think this is finished now

[shinyoshiaki]

thanks!!