Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ノートとRenoteに別々にチャンネルの色を表示する #431

Conversation

poppingmoon
Copy link
Contributor

ノート本体とRenote表示のそれぞれに別々にチャンネルの色のバーを表示するようにしました

Fix #430

@poppingmoon poppingmoon force-pushed the renote-header-channel-color branch from d3e654c to b3ed6e0 Compare November 10, 2023 21:35
@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2023

Codecov Report

Attention: 45 lines in your changes are missing coverage. Please review.

Comparison is base (07e6895) 37.56% compared to head (e1a0ecb) 37.63%.

Files Patch % Lines
lib/view/common/misskey_notes/misskey_note.dart 78.57% 45 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #431      +/-   ##
===========================================
+ Coverage    37.56%   37.63%   +0.06%     
===========================================
  Files          251      251              
  Lines        13282    13300      +18     
===========================================
+ Hits          4990     5005      +15     
- Misses        8292     8295       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poppingmoon poppingmoon force-pushed the renote-header-channel-color branch from b3ed6e0 to 833810f Compare November 10, 2023 21:43
@poppingmoon poppingmoon force-pushed the renote-header-channel-color branch from 833810f to b5664ce Compare November 18, 2023 05:44
@poppingmoon poppingmoon force-pushed the renote-header-channel-color branch 2 times, most recently from 76272ff to bb1ff6c Compare November 27, 2023 10:01
@poppingmoon poppingmoon force-pushed the renote-header-channel-color branch from bb1ff6c to e1a0ecb Compare January 28, 2024 01:38
@shiosyakeyakini-info shiosyakeyakini-info changed the base branch from develop to feature/miria_v2 July 14, 2024 03:12
@shiosyakeyakini-info shiosyakeyakini-info merged commit 330faae into shiosyakeyakini-info:feature/miria_v2 Jul 14, 2024
@shiosyakeyakini-info
Copy link
Owner

🙏🙏

@poppingmoon poppingmoon deleted the renote-header-channel-color branch July 14, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

チャンネルのノートのRenoteがチャンネル外かどうか区別する
3 participants