Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: replace fron "inAppWebView" to "externalApplication" #575

Conversation

Npepperlinux
Copy link
Contributor

LaunchUrlString()LaunchModeをすべてinAppWebViewからexternalApplicationに置き換える提案です。

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 36.61%. Comparing base (bc44391) to head (d488272).

Files Patch % Lines
...ib/view/common/misskey_notes/note_modal_sheet.dart 0.00% 1 Missing ⚠️
lib/view/user_page/user_control_dialog.dart 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #575   +/-   ##
========================================
  Coverage    36.61%   36.61%           
========================================
  Files          257      257           
  Lines        13586    13586           
========================================
  Hits          4974     4974           
  Misses        8612     8612           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shiosyakeyakini-info shiosyakeyakini-info changed the base branch from develop to feature/miria_v2 June 22, 2024 05:11
@shiosyakeyakini-info shiosyakeyakini-info merged commit 041585d into shiosyakeyakini-info:feature/miria_v2 Jun 22, 2024
@Npepperlinux Npepperlinux deleted the fix/open_link_in_default_browser branch June 22, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants