Fix extension conflict with const definition (#213)

shipmonk-rnd · Dec 30, 2024 · f374f53 · f374f53
1 parent 160c1c6
commit f374f53
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 0 deletions.
diff --git a/src/UsedSymbolExtractor.php b/src/UsedSymbolExtractor.php
@@ -426,6 +426,7 @@ private function canBeSymbolName(
             || $tokenAfterName[0] === T_INSTEADOF
             || $tokenAfterName[0] === T_AS
             || $tokenAfterName === ':'
+            || $tokenAfterName === '='
         ) {
             return false;
         }

diff --git a/tests/UsedSymbolExtractorTest.php b/tests/UsedSymbolExtractorTest.php
@@ -59,6 +59,7 @@ public function provideVariants(): iterable
             [],
             [
                 strtolower('PDO') => SymbolKind::CLASSLIKE,
+                strtolower('SESSION_ID') => SymbolKind::CONSTANT,
             ],
         ];
 

diff --git a/tests/data/not-autoloaded/used-symbols/t-string-issues.php b/tests/data/not-autoloaded/used-symbols/t-string-issues.php
@@ -10,6 +10,8 @@
 
 class Test
 {
+    public const string SESSION_ID = '...';
+
     use SomeTrait {
         array_filter insteadof array_values;
         array_map as array_walk;
-Original file line number
+Diff line change
@@ Expand Up / @@ -59,6 +59,7 @@ public function provideVariants(): iterable @@
                 [],
                 [
                     strtolower('PDO') => SymbolKind::CLASSLIKE,
+                    strtolower('SESSION_ID') => SymbolKind::CONSTANT,
                 ],
             ];
@@ Expand Down @@