Remove reserved exit code 255 and replace it with exit code 1 #214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exit code 255 is reserved by PHP: https://www.php.net/manual/en/function.exit.php
While there is no definitive standard on exit codes, 255 is also generally reserved, see the linux documentation project (unofficial source)
This PR removes all usages of exit 255 and replaces it with exit code 1, in line with the changes in #110 where exit code 1 was already used for errors in the JUnitFormatter. Using exit codes 0 and 1 is also in line with symfony console and tools like composer and PHPStan.