Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reserved exit code 255 and replace it with exit code 1 #214

Merged

Conversation

PrinsFrank
Copy link
Contributor

Exit code 255 is reserved by PHP: https://www.php.net/manual/en/function.exit.php

Note: Exit codes should be in the range 0 to 254, the exit code 255 is reserved by PHP and should not be used.

While there is no definitive standard on exit codes, 255 is also generally reserved, see the linux documentation project (unofficial source)

This PR removes all usages of exit 255 and replaces it with exit code 1, in line with the changes in #110 where exit code 1 was already used for errors in the JUnitFormatter. Using exit codes 0 and 1 is also in line with symfony console and tools like composer and PHPStan.

@janedbal janedbal merged commit cff5648 into shipmonk-rnd:master Dec 30, 2024
119 checks passed
@janedbal
Copy link
Member

Seems valid, thank you!

@PrinsFrank PrinsFrank deleted the remove-reserved-exit-code-255 branch December 30, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants