[BUG] Having lava in your view results in FPS drops #1793
Labels
Bug
Something isn't working
Comments
|
Yeah I was worried about this when I made that, performance on weaker computers, but it seemed like everyone i talked to didn't have a problem with it. |
|
I know bay has some sort of particle pref, maybe that could help with low performance pcs while keeping the effect for high performance pcs? |
|
I can also vouch for getting some hefty loss of FPS around lava. Not playing on the greatest rig but handles everywhere else in Shiptest just fine |
|
Some further testing on my machine, I tried tweaking just about every var for the particles individually (max count, spawn rate, lifespan, fade, friction, gradient, colour change), and using different generators for the randomness. Nothing seemed to have an impact on the performance drain on my machine other than just disabling them completely. |
Merged
github-merge-queue bot
pushed a commit
that referenced
this issue
Aug 26, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Fixes #1793 This adds a fuck ton of particles to the game. These are almost entirely ported from tgstation, specifically: tgstation/tgstation#71110 (I was unable to get the editor to work, so this is just the backend fancy stuff) tgstation/tgstation#59869 (particles) tgstation/tgstation#60515 (particles) tgstation/tgstation#74555 (particles) And because atomization is not in my name, I have also done added my own spin on this, and that is making blood show up as a particle effect, instead of mysteriously showing up on the floor. I also made the mysteriously showing up on the floor bit more clearer if you are spilling a lot of blood. Because of the above, I went further and ported DaedalusDock/daedalusdock#79 (blood squirts only) as well for being shot, and some additions I made myself. I am aware using sleep() is bad practice, but I'm not sure how I would avoid using it here outside of rearranging how a lot of things work, so ill just say its "fine" Also gibbing doesn't destroy your body anymore, however it STILL will be very hard to fix you reguardless, since you still fall apart like a lego character, it's just you no longer need to stuff them into a legion corpse. And during testing since it annoyed me, bloodloss effects are more pronounced and harder to ignore, taken mostly from https://github.com/tgstation/TerraGov-Marine-Corps 's bloodloss effects but less severe in a way. And one last thing, bone breaking has sound effects, from Terragov above. Cronch. ## Why It's Good For The Game While i'm not convinced over using particles over hand drawn sprite effects, I cannot deny i see the potential in them, especially here!      ## Changelog :cl: Baystation12, Kapu1178, rye-rice add: Particles! add: Bleeding has better feedback add: Bone breaking now has sound effects add: Getting shot now throws blood squirts! Live through the somme for REAL this time! balance: gibbing no longer destroys your chest, no more legion transfers! fix: Lava particles should no longer destroy your FPS /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Co-authored-by: retlaw34 <[email protected]>
Constellado
pushed a commit
to Constellado/PentestOld
that referenced
this issue
Aug 27, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Fixes shiptest-ss13#1793 This adds a fuck ton of particles to the game. These are almost entirely ported from tgstation, specifically: tgstation/tgstation#71110 (I was unable to get the editor to work, so this is just the backend fancy stuff) tgstation/tgstation#59869 (particles) tgstation/tgstation#60515 (particles) tgstation/tgstation#74555 (particles) And because atomization is not in my name, I have also done added my own spin on this, and that is making blood show up as a particle effect, instead of mysteriously showing up on the floor. I also made the mysteriously showing up on the floor bit more clearer if you are spilling a lot of blood. Because of the above, I went further and ported DaedalusDock/daedalusdock#79 (blood squirts only) as well for being shot, and some additions I made myself. I am aware using sleep() is bad practice, but I'm not sure how I would avoid using it here outside of rearranging how a lot of things work, so ill just say its "fine" Also gibbing doesn't destroy your body anymore, however it STILL will be very hard to fix you reguardless, since you still fall apart like a lego character, it's just you no longer need to stuff them into a legion corpse. And during testing since it annoyed me, bloodloss effects are more pronounced and harder to ignore, taken mostly from https://github.com/tgstation/TerraGov-Marine-Corps 's bloodloss effects but less severe in a way. And one last thing, bone breaking has sound effects, from Terragov above. Cronch. ## Why It's Good For The Game While i'm not convinced over using particles over hand drawn sprite effects, I cannot deny i see the potential in them, especially here!      ## Changelog :cl: Baystation12, Kapu1178, rye-rice add: Particles! add: Bleeding has better feedback add: Bone breaking now has sound effects add: Getting shot now throws blood squirts! Live through the somme for REAL this time! balance: gibbing no longer destroys your chest, no more legion transfers! fix: Lava particles should no longer destroy your FPS /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Co-authored-by: retlaw34 <[email protected]>
MysticalFaceLesS
pushed a commit
to CeladonSS13/Shiptest
that referenced
this issue
Sep 2, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Fixes shiptest-ss13#1793 This adds a fuck ton of particles to the game. These are almost entirely ported from tgstation, specifically: tgstation/tgstation#71110 (I was unable to get the editor to work, so this is just the backend fancy stuff) tgstation/tgstation#59869 (particles) tgstation/tgstation#60515 (particles) tgstation/tgstation#74555 (particles) And because atomization is not in my name, I have also done added my own spin on this, and that is making blood show up as a particle effect, instead of mysteriously showing up on the floor. I also made the mysteriously showing up on the floor bit more clearer if you are spilling a lot of blood. Because of the above, I went further and ported DaedalusDock/daedalusdock#79 (blood squirts only) as well for being shot, and some additions I made myself. I am aware using sleep() is bad practice, but I'm not sure how I would avoid using it here outside of rearranging how a lot of things work, so ill just say its "fine" Also gibbing doesn't destroy your body anymore, however it STILL will be very hard to fix you reguardless, since you still fall apart like a lego character, it's just you no longer need to stuff them into a legion corpse. And during testing since it annoyed me, bloodloss effects are more pronounced and harder to ignore, taken mostly from https://github.com/tgstation/TerraGov-Marine-Corps 's bloodloss effects but less severe in a way. And one last thing, bone breaking has sound effects, from Terragov above. Cronch. ## Why It's Good For The Game While i'm not convinced over using particles over hand drawn sprite effects, I cannot deny i see the potential in them, especially here!      ## Changelog :cl: Baystation12, Kapu1178, rye-rice add: Particles! add: Bleeding has better feedback add: Bone breaking now has sound effects add: Getting shot now throws blood squirts! Live through the somme for REAL this time! balance: gibbing no longer destroys your chest, no more legion transfers! fix: Lava particles should no longer destroy your FPS /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Co-authored-by: retlaw34 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Round ID: Not on any of the shiptest servers, any round works however
Testmerges:
Reproduction:
On my fairly weak machine, I've noticed that going next to a lake of lava in places such as the lava planet will result in a major FPS drop, which I feel like #1569 may have something to do with this?
Might be hard to reproduce since this will likely depend on how good your computer is.
The text was updated successfully, but these errors were encountered: