Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bay clicky noises #130

Merged
merged 10 commits into from
Sep 24, 2021
Merged

bay clicky noises #130

merged 10 commits into from
Sep 24, 2021

Conversation

rye-rice
Copy link
Member

@rye-rice rye-rice commented Aug 8, 2021 •
edited
Loading

About The Pull Request

Adds the typing noises when clicking a computer, switch, or sleeper

Also adds the computer sprites from @Quantum-M gonb

Why It's Good For The Game

I think its very atmospheric, and helps the atmosphere of the game

Changelog

🆑
soundadd: bay clicking sounds
/:cl:

retlaw34 added 2 commits August 7, 2021 04:03
@keywordlabeler keywordlabeler bot added Feature REALLY causes more bugs in the future that we won't know about. Sound USSR Anthem 2.66 MB file. labels Aug 8, 2021
@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. Sprites A bikeshed full of soulless bikes. labels Aug 8, 2021
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Aug 16, 2021
@github-actions github-actions bot removed Merge Conflict Use Git Hooks, you're welcome. Map Change Tile placing is hard. Thank you for your service. labels Aug 18, 2021
@ZephyrTFA ZephyrTFA added the Test Merged They've done it for free. label Aug 22, 2021
@ghost
Copy link

ghost commented Aug 27, 2021

My criticism is that the sprites really need to be made smaller, and also you need to have sprites for computer construction.

@rye-rice
Copy link
Member Author

Quantum is working on improving them at the moment

@rye-rice rye-rice changed the title bay clicky noises along with new computer sprites bay clicky noises Aug 30, 2021
@shiptest-server
Copy link
Member

Test Merge Removed

@shiptest-server
Copy link
Member

Test Merge Deployed

Server Instance

shiptest

Revision

Origin: aabc6f1
Pull Request: 281b094
Server: 4a612b6abc77d3aaae270b65dc4c94667e4d6be2

@shiptest-server
Copy link
Member

Test Merge Updated

Server Instance

shiptest

Revision

Origin: 293bad3
Pull Request: 281b094
Server: 2c17e761a3dbe846412b0eb5224178d8c7dfc1e4

@shiptest-server
Copy link
Member

Test Merge Updated

Server Instance

shiptest

Revision

Origin: d796599
Pull Request: 281b094
Server: 72d94bef2620899bd315f660ccb547df14ffc328

@shiptest-server
Copy link
Member

Test Merge Updated

Server Instance

shiptest

Revision

Origin: dd854e7
Pull Request: 281b094
Server: d097fa6e32a13458e756307a43c1764f99b243bc

@shiptest-server
Copy link
Member

Test Merge Updated

Server Instance

shiptest

Revision

Origin: 4d98cdc
Pull Request: 281b094
Server: 9a29cfa82da92d64f18a8f8bcd69d3ea934be1ac

@shiptest-server
Copy link
Member

Test Merge Updated

Server Instance

shiptest

Revision

Origin: f789e74
Pull Request: 281b094
Server: fec71ade6e716fb63d267abca95b86e22f5eb182

@shiptest-server
Copy link
Member

Test Merge Removed

@shiptest-server
Copy link
Member

Test Merge Deployed

Server Instance

shiptest

Revision

Origin: bf2a3d7
Pull Request: 281b094
Server: ca0ff8b9f76846976a9d8d2ec5e18cf60ecd28be

@TheNeoGamer42
Copy link
Contributor

empty computer frames are completely invisible right now

@AsciiSquid AsciiSquid mentioned this pull request Sep 4, 2021
Closed
@shiptest-server
Copy link
Member

Test Merge Removed

@Pontenerd Pontenerd mentioned this pull request Sep 19, 2021
Closed
@rye-rice
Copy link
Member Author

i forgot i made this pr

@rye-rice rye-rice marked this pull request as ready for review September 22, 2021 05:56
@rye-rice
Copy link
Member Author

i swear i was going to add something else to this pr but i forgot

@rye-rice
Copy link
Member Author

you can merge it if you want

@MarkSuckerberg MarkSuckerberg merged commit 0dfb32d into shiptest-ss13:master Sep 24, 2021
MarkSuckerberg pushed a commit that referenced this pull request Sep 24, 2021
@actions-user
Automatic changelog generation for PR #130 [ci skip]
2cfe595
@Hardly3D Hardly3D mentioned this pull request Mar 25, 2022
Merged
@SinguloBot SinguloBot mentioned this pull request May 2, 2022
Open
@AustationBot AustationBot mentioned this pull request May 2, 2022
Merged
@SinguloBot SinguloBot mentioned this pull request May 2, 2022
Closed
@rye-rice rye-rice mentioned this pull request Jul 28, 2022
Merged
@ZephyrTFA ZephyrTFA removed the Test Merged They've done it for free. label Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZephyrTFA ZephyrTFA ZephyrTFA left review comments

@MarkSuckerberg MarkSuckerberg MarkSuckerberg approved these changes

Assignees
No one assigned
Labels
Feature REALLY causes more bugs in the future that we won't know about. Sound USSR Anthem 2.66 MB file. Sprites A bikeshed full of soulless bikes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rye-rice @shiptest-server @TheNeoGamer42 @ZephyrTFA @MarkSuckerberg