-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ports "Ports "Revives "Adds sound effects to surgeries"" and others" and "Adds medical sounds" #1317
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove all shiptest edits and move the files out of the whitesands folder
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
1 similar comment
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: nmajask <[email protected]>
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 14 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry we've been dragging our feet on this... I'll get it testmerged.
all good, as long as its merged eventually |
…and "Adds medical sounds" (shiptest-ss13#1317)
About The Pull Request
Ports two (2) PRs from yogs and bay (technically they are both ports from yogs but shhhh), those being "Ports "Revives "Adds sound effects to surgeries"" and others" #14390 by some idiot and "Adds medical sounds" #21268 by comma. In short, adds surgery sounds to most surgery steps and when applying bruise packs/ointment. Also adds sounds for starting surgeries for some nice feedback for when a surgery is/isn't started. May be a bit loud, so I can make it quieter if needed. Bone sounds are from freesound.org.
Why It's Good For The Game
More sounds good, and makes surgery a little more involving than just clicking on the horizontal person.
Changelog
🆑 maxspells, TheBoondock, MrMelbert, comma, nmajask
soundadd: added sounds to surgery steps
soundadd: added sound effects to a bunch of medical items
spellcheck: fixed revive surgery saying "shock body" instead of "shock brain"
/:cl: