Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOOC Fixes #2246

Merged
merged 9 commits into from
Aug 18, 2023
Merged

LOOC Fixes #2246

merged 9 commits into from
Aug 18, 2023

Conversation

MarkSuckerberg
Copy link
Member

@MarkSuckerberg MarkSuckerberg commented Aug 3, 2023

About The Pull Request

See changelog

Why It's Good For The Game

LOOC is used fairly frequently here, so I might as well keep it up to scratch with normal OOC at least.

Changelog

🆑
add: You can now configure LOOC and mentorsay in chat tabs
fix: (Un)Muting LOOC now actually works.
admin: You can now change the global LOOC colour. Because, why not?
admin: LOOC now shows up in the OOC tab of the logging panel for players
/:cl:

@github-actions github-actions bot added Admin They do it for free. Code change Watch something violently break. labels Aug 3, 2023
@MarkSuckerberg
Copy link
Member Author

also I just want to say this came to my attention because LOOC checked if you had the bwoink sound muted instead of the LOOC mute toggle enabled. I will not elaborate

@thgvr
Copy link
Member

thgvr commented Aug 3, 2023

it would be really epic if LOOC was a separate section toggle like OOC is for tabs.

@BarteG44
Copy link

BarteG44 commented Aug 3, 2023

rune chat for LOOC would be really nice too. the most frequent use for it is to talk to newer players but most of them don't look in the chat tab

@MarkSuckerberg
Copy link
Member Author

it would be really epic if LOOC was a separate section toggle like OOC is for tabs.

yeah that might be cool, probably not terribly hard

rune chat for LOOC would be really nice too. the most frequent use for it is to talk to newer players but most of them don't look in the chat tab

possibly, no idea how I'd show that as LOOC versus IC speaking though, though I'd be down to hear ideas

@BarteG44
Copy link

BarteG44 commented Aug 3, 2023

i was thinking that it could look something like goon
obraz
maybe give it a different color too

@github-actions github-actions bot added the TGUI label Aug 3, 2023
@MarkSuckerberg
Copy link
Member Author

Could work, also, I made mentorchat and LOOC both configurable in chat tabs, updating the PR desc

@MarkSuckerberg
Copy link
Member Author

Added an attempt at runechat LOOC, untested, since I'm away from my windows PC atm

@MarkSuckerberg MarkSuckerberg requested a review from a team as a code owner August 4, 2023 16:58
@github-actions github-actions bot added the Sprites A bikeshed full of soulless bikes. label Aug 4, 2023
@MarkSuckerberg MarkSuckerberg added this pull request to the merge queue Aug 18, 2023
Merged via the queue into shiptest-ss13:master with commit 158d192 Aug 18, 2023
@MarkSuckerberg MarkSuckerberg deleted the fixes-looc branch August 18, 2023 06:45
MarkSuckerberg added a commit to MarkSuckerberg/Shiptest that referenced this pull request Sep 13, 2023
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
See changelog
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
LOOC is used fairly frequently here, so I might as well keep it up to
scratch with normal OOC at least.
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
add: You can now configure LOOC and mentorsay in chat tabs
fix: (Un)Muting LOOC now actually works.
admin: You can now change the global LOOC colour. Because, why not?
admin: LOOC now shows up in the OOC tab of the logging panel for players
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
MarkSuckerberg pushed a commit to MarkSuckerberg/Shiptest that referenced this pull request Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin They do it for free. Code change Watch something violently break. Sprites A bikeshed full of soulless bikes. TGUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants