Stops Issues from Getting Tags From Referenced Testmerges #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keywordlabeler
bot
added
the
Do Not Merge
|
As an example of said behavior, the bot added the "do not merge" tag because [DNM] is in the description of the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
The keywordlabeler bot has been adding the "do not merge" tag to several issues. This was caused by it searching the body of the issues and seeing the [DNM] string included in the titles of some of the testmerges. An example is #232.
This can be fixed by telling the bot to stop searching the body of the issue when deciding what tags to add. However there doesn't appear to be a way to tell it to treat issues and PRs differently, so that means it will also not search a PR's body.
This will make it so the search strings for tags must be in the title of PRs and issues. However it appears this is already the standard. I don't know if this is the way you want this fixed, so I'm leaving this here as an option.