tiny fax related fixes #3715
Merged
tiny fax related fixes #3715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Map Change
|
As the resident Mech Peddler I'm going to kith you on the mouss. Also I didn't know admins didn't get a sound when faction faxes were sent, that's fucked up, good catch. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 9, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request * Adds a NT fax machine to the Delta-class * Replaces PGF vessels' fax machines with correct subtypes * Replaces the Lavaland listening post's and Sandplanet distillery's faxes with correct subtypes * Fax requests now make a sound alert * Fax machines are now, by default, offset by 6 pixels <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game consistency good. also we probably should stop missing faxes <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: add: The Delta-class now has a fax machine add: Fax machines are now offset by 6 pixels fix: Fixed some faxes' subtypes admin: Fax requests now make a noise /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
MrCat15352
pushed a commit
to MrCat15352/MrCat
that referenced
this pull request
Dec 27, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request * Adds a NT fax machine to the Delta-class * Replaces PGF vessels' fax machines with correct subtypes * Replaces the Lavaland listening post's and Sandplanet distillery's faxes with correct subtypes * Fax requests now make a sound alert * Fax machines are now, by default, offset by 6 pixels <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game consistency good. also we probably should stop missing faxes <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: add: The Delta-class now has a fax machine add: Fax machines are now offset by 6 pixels fix: Fixed some faxes' subtypes admin: Fax requests now make a noise /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Why It's Good For The Game
consistency good. also we probably should stop missing faxes
Changelog
🆑
add: The Delta-class now has a fax machine
add: Fax machines are now offset by 6 pixels
fix: Fixed some faxes' subtypes
admin: Fax requests now make a noise
/:cl: