Fixes a runtime with SecurEye and updates bodycamera descriptions #4103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+176
to
+180
| if(!active_camera) | ||
| show_camera_static() | ||
| return | ||
| else if (active_camera.loc == null) | ||
| show_camera_static() |
There was a problem hiding this comment.
any reason not to slap an OR here instead?
There was a problem hiding this comment.
The reason it's staggered like this is because if no active camera is selected, the reference would be set to null, and this was causing runtimes when active_camera was null (because null.loc would throw a runtime)
This should check if active_camera is not null first, and then evaluate if the location is null
Truth be told, I could've made lines 179 through 181 their own if function instead of chaining it up with the if function starting at line 176, but the behavior is functionally the same
shiptest-server
pushed a commit
that referenced
this pull request
Feb 8, 2025
MrCat15352
pushed a commit
to MrCat15352/MrCat
that referenced
this pull request
Feb 16, 2025
…iptest-ss13#4103) <!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request This PR should fix a runtime that had been popping up with bodycameras during their testmerges. It should also fix part of the description for them that I'd erroneously made bold. ## Why It's Good For The Game Runtimes are not good, and the description was a little confusing in what words were made bold. A single missing character causes untold havoc yet again. ## Changelog :cl: fix: fixed securEye runtime fix: fixed bodycamera description typo /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This PR should fix a runtime that had been popping up with bodycameras during their testmerges. It should also fix part of the description for them that I'd erroneously made bold.
Why It's Good For The Game
Runtimes are not good, and the description was a little confusing in what words were made bold. A single missing character causes untold havoc yet again.
Changelog
🆑
fix: fixed securEye runtime
fix: fixed bodycamera description typo
/:cl: