Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plexagon ID management can assign job's from the ship's job list. #4128

Merged
merged 3 commits into from
Feb 14, 2025

Conversation

ritorizo
Copy link
Contributor

@ritorizo ritorizo commented Feb 2, 2025

About The Pull Request

  • If a console get started on a ship it will now be able to assign an ID to any job that can be joined on the ship.
  • This behavior can be extended to any computer if you copy Plexagon acces management to another computer or yoink the hard drive, but you'll still need a card with proper access (including ship access) to do so.

The old behavior is still present if Plexagon is not connected to any ship.

Why It's Good For The Game

Id management felt off since we were only able to assign crew to station job. With this pr we will now be able to actualy demote/promote crew.

Changelog

🆑
add: Assigning a crew to a job that comes on the ship is now possible with command consoles.
🆑

@github-actions github-actions bot added TGUI Code change Watch something violently break. labels Feb 2, 2025
@ritorizo ritorizo marked this pull request as draft February 2, 2025 22:11
@ritorizo
Copy link
Contributor Author

ritorizo commented Feb 2, 2025

Nevermind there are runtimes

@ritorizo ritorizo marked this pull request as ready for review February 2, 2025 22:46
@ritorizo
Copy link
Contributor Author

ritorizo commented Feb 3, 2025

no more runtime =)

@FalloutFalcon FalloutFalcon added this pull request to the merge queue Feb 14, 2025
Merged via the queue into shiptest-ss13:master with commit f7361b4 Feb 14, 2025
16 checks passed
MrCat15352 pushed a commit to MrCat15352/MrCat that referenced this pull request Feb 16, 2025
…iptest-ss13#4128)

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

- If a console get started on a ship it will now be able to assign an ID
to any job that can be joined on the ship.
- This behavior can be extended to any computer if you copy Plexagon
acces management to another computer or yoink the hard drive, but you'll
still need a card with proper access (including ship access) to do so.

The old behavior is still present if Plexagon is not connected to any
ship.

## Why It's Good For The Game

Id management felt off since we were only able to assign crew to station
job. With this pr we will now be able to actualy demote/promote crew.

## Changelog

:cl:
add: Assigning a crew to a job that comes on the ship is now possible
with command consoles.
:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Co-authored-by: ritorizo <ritorizo@localhost>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. TGUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants