Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chain of Command - IRMG Rank Pins #4134

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

randy10122
Copy link
Contributor

About The Pull Request

Implements uniform-attachable rank pins for every member (in-game and not implemented) of the IRMG! At a glance, you can now easily tell who is technically above or below you in the Group (as if that matters)!

What job/rank corresponds to each pin (Class 1 is applied to Inteq ERT at the moment):
image2
Without the clutter:
image
And, and mspaint mockup of the direct rank structure (using modern NATO paygrades as a reference point) that was formed in loredev the other day:
image

Also, this is all built to be re-usable if we ever want to do something similar for another faction.

Why It's Good For The Game

Flavour! Flavour is awesome. Sovl

Also, Inteq not having any gold on their turtlenecks is a travesty. This fixes that!

Changelog

🆑
add: Rank pins for Inteq! You'll find them pinned to your uniform when you wake up from cryo.
/:cl:

@randy10122 randy10122 requested a review from a team as a code owner February 3, 2025 21:38
@github-actions github-actions bot added Sprites A bikeshed full of soulless bikes. Code change Watch something violently break. labels Feb 3, 2025
@randy10122
Copy link
Contributor Author

oh yeah i forgot to do different worn sprites for kepori because i have no idea where i would start doing that

@meemofcourse
Copy link
Contributor

can't believe we got this for inteq before pgf

@randy10122
Copy link
Contributor Author

can't believe we got this for inteq before pgf

i ran it through my mind the other day - pgf already sort of has the cloaks and those are a little more swag than just pins

@Apogee-dev
Copy link
Contributor

ngr and clip next 🙂

@randy10122
Copy link
Contributor Author

ngr and clip next 🙂

would love to actually

@thgvr
Copy link
Member

thgvr commented Feb 13, 2025

The icons for this do not really work, they have floating pieces and look more just like the symbol rather than a pin you would wear. Also, what's up with the duplicated mob states?

@randy10122
Copy link
Contributor Author

The icons for this do not really work, they have floating pieces and look more just like the symbol rather than a pin you would wear.

Any actual suggestions? I'm not really, like, a world-class spriter.

Also, what's up with the duplicated mob states?

Accessories are handled strangely. I'm potentially too stupid to figure out an actually clean way to have them render as intended. You can see the other methods I attempted in commits 8b3444a through 44b44d9.

@thgvr
Copy link
Member

thgvr commented Feb 13, 2025

Actually I remember why, accessories are handled differently than pretty much all other rendering code and thus don't have the same features. It's awful and I hate it.

For the sprite, I'd imagine something more like a patch that's affixable to clothing, where the gold bits (that you've already made) would be more of an embossment. Another issue arises in any curved or diagonal sections you've made - they use a gradient of colors (3 shades in a row in this case) where having it be continuous color for most of it would make the shape much better.

I'd also really recommend looking into world icon for this - they're huge and I don't think it would be difficult to make a smaller sized version.

@randy10122
Copy link
Contributor Author

Yeah, alright - I'll give that a shot when I get a minute.


/obj/item/clothing/accessory/rank_pin/inteq/artificer_c1 // unused in game
name = "rank pins - IE-3"
desc = "A golden pin designating the wearer as an Artificer Clas One of the IRMG. The engine room is a temple raised to the God of the Engineer."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*Class and perhaps plural "Engineer" to "Engineers"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one is quoting a filk song smh smh


/obj/item/clothing/accessory/rank_pin/inteq/inspector
name = "rank pins - IO-1"
desc = "A golden pin designating the wearer as an Inpsector of the IRMG. I assume all your papers are in order?"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*Inspector


/obj/item/clothing/accessory/rank_pin/inteq/maa
name = "rank pins - IO-2"
desc = "A golden pin designating the wearer as a Master at Arms of the IRMG. The armoury is your home."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The U.S. English "armory" spelling is used predominately in the codebase, and it should be the same here.


/obj/item/clothing/accessory/rank_pin/inteq/artificer_hon
name = "rank pins - IO-3"
desc = "A golden pin designating the wearer as an Honourable Artificer of the IRMG. The Vanguard rules upon the bridge, and you reign here below."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto as above. The job manifest uses the U.S. spelling of "Honorable".


/obj/item/clothing/accessory/rank_pin/inteq/corpsman_hon
name = "rank pins - IO-3"
desc = "A golden pin designating the wearer as an Honourable Corpsman of the IRMG. You'll do your best, and run another test, and pour yourself another mug of brew."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*Honorable


/obj/item/clothing/accessory/rank_pin/inteq/enforcer_hon
name = "rank pins - IO-4"
desc = "A golden pin designating the wearer as an Enforcer Honour Guard of the IRMG. Someone important is in town - you better keep them safe."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*Honor


/obj/item/clothing/accessory/rank_pin/inteq/vanguard_hon
name = "rank pins - IO-6"
desc = "A golden pin designating the wearer as an Honourable Vanguard of the IRMG. A title such as this demands respect."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*Honorable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants