-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chain of Command - IRMG Rank Pins #4134
base: master
Are you sure you want to change the base?
Conversation
oh yeah i forgot to do different worn sprites for kepori because i have no idea where i would start doing that |
can't believe we got this for inteq before pgf |
i ran it through my mind the other day - pgf already sort of has the cloaks and those are a little more swag than just pins |
ngr and clip next 🙂 |
would love to actually |
The icons for this do not really work, they have floating pieces and look more just like the symbol rather than a pin you would wear. Also, what's up with the duplicated mob states? |
Any actual suggestions? I'm not really, like, a world-class spriter.
Accessories are handled strangely. I'm potentially too stupid to figure out an actually clean way to have them render as intended. You can see the other methods I attempted in commits 8b3444a through 44b44d9. |
Actually I remember why, accessories are handled differently than pretty much all other rendering code and thus don't have the same features. It's awful and I hate it. For the sprite, I'd imagine something more like a patch that's affixable to clothing, where the gold bits (that you've already made) would be more of an embossment. Another issue arises in any curved or diagonal sections you've made - they use a gradient of colors (3 shades in a row in this case) where having it be continuous color for most of it would make the shape much better. I'd also really recommend looking into world icon for this - they're huge and I don't think it would be difficult to make a smaller sized version. |
Yeah, alright - I'll give that a shot when I get a minute. |
|
||
/obj/item/clothing/accessory/rank_pin/inteq/artificer_c1 // unused in game | ||
name = "rank pins - IE-3" | ||
desc = "A golden pin designating the wearer as an Artificer Clas One of the IRMG. The engine room is a temple raised to the God of the Engineer." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*Class and perhaps plural "Engineer" to "Engineers"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this one is quoting a filk song smh smh
|
||
/obj/item/clothing/accessory/rank_pin/inteq/inspector | ||
name = "rank pins - IO-1" | ||
desc = "A golden pin designating the wearer as an Inpsector of the IRMG. I assume all your papers are in order?" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*Inspector
|
||
/obj/item/clothing/accessory/rank_pin/inteq/maa | ||
name = "rank pins - IO-2" | ||
desc = "A golden pin designating the wearer as a Master at Arms of the IRMG. The armoury is your home." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The U.S. English "armory" spelling is used predominately in the codebase, and it should be the same here.
|
||
/obj/item/clothing/accessory/rank_pin/inteq/artificer_hon | ||
name = "rank pins - IO-3" | ||
desc = "A golden pin designating the wearer as an Honourable Artificer of the IRMG. The Vanguard rules upon the bridge, and you reign here below." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto as above. The job manifest uses the U.S. spelling of "Honorable".
|
||
/obj/item/clothing/accessory/rank_pin/inteq/corpsman_hon | ||
name = "rank pins - IO-3" | ||
desc = "A golden pin designating the wearer as an Honourable Corpsman of the IRMG. You'll do your best, and run another test, and pour yourself another mug of brew." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*Honorable
|
||
/obj/item/clothing/accessory/rank_pin/inteq/enforcer_hon | ||
name = "rank pins - IO-4" | ||
desc = "A golden pin designating the wearer as an Enforcer Honour Guard of the IRMG. Someone important is in town - you better keep them safe." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*Honor
|
||
/obj/item/clothing/accessory/rank_pin/inteq/vanguard_hon | ||
name = "rank pins - IO-6" | ||
desc = "A golden pin designating the wearer as an Honourable Vanguard of the IRMG. A title such as this demands respect." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*Honorable
About The Pull Request
Implements uniform-attachable rank pins for every member (in-game and not implemented) of the IRMG! At a glance, you can now easily tell who is technically above or below you in the Group (as if that matters)!
What job/rank corresponds to each pin (Class 1 is applied to Inteq ERT at the moment):
![image2](https://private-user-images.githubusercontent.com/88034663/409292858-db153576-7230-40d5-a7ee-f2d0fd4c2ae6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2MDkzNzYsIm5iZiI6MTczOTYwOTA3NiwicGF0aCI6Ii84ODAzNDY2My80MDkyOTI4NTgtZGIxNTM1NzYtNzIzMC00MGQ1LWE3ZWUtZjJkMGZkNGMyYWU2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDA4NDQzNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWI4Mzc0ZDE4MTNiMWI2NjE3MWM1OGUyZjcxNWFhZmVmMGU3NDQyMTU2OTI2NzVmNDUwNzQ0MjdkMDI4YmViYTQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.zbNT-5G_zZy5R-yJQtIkKtzk2GvhwjWZoHQvCvblgSg)
![image](https://private-user-images.githubusercontent.com/88034663/409292870-de81e5f3-79b8-4a6c-a6f9-b582d4ab4212.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2MDkzNzYsIm5iZiI6MTczOTYwOTA3NiwicGF0aCI6Ii84ODAzNDY2My80MDkyOTI4NzAtZGU4MWU1ZjMtNzliOC00YTZjLWE2ZjktYjU4MmQ0YWI0MjEyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDA4NDQzNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTAxMjc3NDU3ZjJjMjAyMWVhZGU0MGVlNDkyNTE2ZDEwZDA2M2ZiNWNiNTQ1NThjY2UwNjE3OTI1MjBjYjllNDImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.AQdscLsSknmxf8lJJG6IM_MRGvGco3jWSFuyn-6gvLo)
![image](https://private-user-images.githubusercontent.com/88034663/409293789-cde683f5-71f3-47cc-94b5-bf65c5740c74.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2MDkzNzYsIm5iZiI6MTczOTYwOTA3NiwicGF0aCI6Ii84ODAzNDY2My80MDkyOTM3ODktY2RlNjgzZjUtNzFmMy00N2NjLTk0YjUtYmY2NWM1NzQwYzc0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDA4NDQzNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTUwOTQ0NmI4YmVhNGY5YTAzMGY1MjdlMjA3NGYyZDRkYjRiNWQ2MzY5NGRiOWM1NmEyYjQ2MDQ2OGI3MmIzOTMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.DwOb_-HYSyL098liCIHYomI9PA-C8cQONWvr6CxI7Cc)
Without the clutter:
And, and mspaint mockup of the direct rank structure (using modern NATO paygrades as a reference point) that was formed in loredev the other day:
Also, this is all built to be re-usable if we ever want to do something similar for another faction.
Why It's Good For The Game
Flavour! Flavour is awesome. Sovl
Also, Inteq not having any gold on their turtlenecks is a travesty. This fixes that!
Changelog
🆑
add: Rank pins for Inteq! You'll find them pinned to your uniform when you wake up from cryo.
/:cl: