Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the Solarian Common language. #4237

Merged
merged 19 commits into from
Feb 28, 2025

Conversation

Aquidu
Copy link
Contributor

@Aquidu Aquidu commented Feb 20, 2025

About The Pull Request

Adds Solarian Common, a language for Humans and SolCon jobs, pulling syllables from German, Swiss, Portuguese, Swahili, Dutch, and Afrikaans.

Screenshot (3563)
Screenshot (3564)

Why It's Good For The Game

Solarians currently speak Galactic Common, which doesn't make much sense if they developed their own culture prior to space travel. This PR gives them their own unique language to speak, as well as makes Humans a tad more unique, having their own language, in the same way Sarathi and Elzu can speak Kalixcian.

Changelog

🆑
add: Adds Solarian Common for SolCon jobs and humans.
/:cl:

@Aquidu Aquidu requested a review from a team as a code owner February 20, 2025 17:04
@github-actions github-actions bot added DME Edit Sprites A bikeshed full of soulless bikes. Code change Watch something violently break. labels Feb 20, 2025
@Apogee-dev
Copy link
Contributor

Apogee-dev commented Feb 21, 2025

Should probably mix in some Malay and/or Samoan somehow, thinking about it

@Aquidu
Copy link
Contributor Author

Aquidu commented Feb 21, 2025

Should probably mix in some Malay somehow, thinking about it

i really wanted to but the website i was using for a guide didn't have malay as a language option

@Apogee-dev
Copy link
Contributor

Should probably mix in some Malay somehow, thinking about it

i really wanted to but the website i was using for a guide didn't have malay as a language option

Try Indonesian, it’s very nearly the same thing

@Imaginos16
Copy link
Member

As the solgov writer, huge thanks for creating this, but there's one more thing needed before it's complete! Please make sure that instead of Solarian Common, it's called Solarian International Standard (Often abbreviated to SIS)

@Aquidu
Copy link
Contributor Author

Aquidu commented Feb 22, 2025

As the solgov writer, huge thanks for creating this, but there's one more thing needed before it's complete! Please make sure that instead of Solarian Common, it's called Solarian International Standard (Often abbreviated to SIS)

just did(i hope just calling it "solarian" in code is still acceptable), i hope this pr lives up to your vision

Copy link
Member

@Imaginos16 Imaginos16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the solgov writer, huge thanks for creating this, but there's one more thing needed before it's complete! Please make sure that instead of Solarian Common, it's called Solarian International Standard (Often abbreviated to SIS)

just did(i hope just calling it "solarian" in code is still acceptable), i hope this pr lives up to your vision

Looks good! Thanks for finally making it.

@SomeguyManperson SomeguyManperson added this pull request to the merge queue Feb 28, 2025
@SomeguyManperson SomeguyManperson removed this pull request from the merge queue due to a manual request Feb 28, 2025
@SomeguyManperson SomeguyManperson added this pull request to the merge queue Feb 28, 2025
Merged via the queue into shiptest-ss13:master with commit 0f755a7 Feb 28, 2025
16 checks passed
@Aquidu Aquidu deleted the solariancommon branch February 28, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. DME Edit Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants