Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PIDs returned by process.Pids() should be sorted #752

Closed
Lomanic opened this issue Aug 20, 2019 · 1 comment · Fixed by #754
Closed

PIDs returned by process.Pids() should be sorted #752

Lomanic opened this issue Aug 20, 2019 · 1 comment · Fixed by #754
Assignees
@Lomanic
Labels
package:process

Comments

@Lomanic
Copy link
Collaborator

Lomanic commented Aug 20, 2019

PIDs returned by process.Pids() should be sorted so we have consistency across different platforms (not every PIDs are sorted on Windows for example) .

This the counterpart issue of giampaolo/psutil#1437 for gopsutil
@Lomanic Lomanic self-assigned this Aug 22, 2019
@Lomanic
Copy link
Collaborator Author

Lomanic commented Aug 22, 2019

I already have something functional, I will submit a PR in the coming days.

Lomanic added a commit to Lomanic/gopsutil that referenced this issue Aug 24, 2019
@Lomanic
[process] Fix shirou#752 sort PIDS returned by process.Pids()
b4e7dae
Lomanic added a commit to Lomanic/gopsutil that referenced this issue Aug 24, 2019
@Lomanic
[process] Fix shirou#752 sort PIDS returned by process.Pids()
3eefe64
@Lomanic Lomanic mentioned this issue Aug 24, 2019
Merged
shirou added a commit that referenced this issue Aug 24, 2019
@shirou
Merge pull request #754 from Lomanic/issue752
dad54b9 
[process] Fix #752 sort PIDS returned by process.Pids()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lomanic Lomanic

Labels
package:process
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[process] Fix #752 sort PIDS returned by process.Pids() Lomanic/gopsutil
1 participant
@Lomanic