Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[disk][linux] add HOST_PROC_MOUNTINFO #1272

Merged
merged 1 commit into from
Apr 1, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,9 @@ environment variable.
You can set an alternative location to `/dev` by setting the `HOST_DEV`
environment variable.

You can set an alternative location to `/proc/N/mountinfo` by setting the
`HOST_PROC_MOUNTINFO` environment variable.

## Documentation

see http://godoc.org/github.com/shirou/gopsutil
Expand Down
25 changes: 19 additions & 6 deletions disk/disk_linux.go
Original file line number Diff line number Diff line change
Expand Up @@ -235,9 +235,10 @@ var fsTypeMap = map[int64]string{
ZFS_SUPER_MAGIC: "zfs", /* 0x2FC12FC1 local */
}

// readMountFile reads mountinfo or mounts file under /proc/1 or /proc/self
// readMountFile reads mountinfo or mounts file under the specified root path
// (eg, /proc/1, /proc/self, etc)
func readMountFile(root string) (lines []string, useMounts bool, filename string, err error) {
filename = common.HostProc(path.Join(root, "mountinfo"))
filename = path.Join(root, "mountinfo")
lines, err = common.ReadLines(filename)
if err != nil {
var pathErr *os.PathError
Expand All @@ -246,7 +247,7 @@ func readMountFile(root string) (lines []string, useMounts bool, filename string
}
// if kernel does not support 1/mountinfo, fallback to 1/mounts (<2.6.26)
useMounts = true
filename = common.HostProc(path.Join(root, "mounts"))
filename = path.Join(root, "mounts")
lines, err = common.ReadLines(filename)
if err != nil {
return
Expand All @@ -257,10 +258,22 @@ func readMountFile(root string) (lines []string, useMounts bool, filename string
}

func PartitionsWithContext(ctx context.Context, all bool) ([]PartitionStat, error) {
lines, useMounts, filename, err := readMountFile("1")
// by default, try "/proc/1/..." first
root := common.HostProc(path.Join("1"))

// force preference for dirname of HOST_PROC_MOUNTINFO, if set #1271
hpmPath := os.Getenv("HOST_PROC_MOUNTINFO")
if hpmPath != "" {
root = filepath.Dir(hpmPath)
}

lines, useMounts, filename, err := readMountFile(root)
if err != nil {
// fallback to "/proc/self/mountinfo" #1159
lines, useMounts, filename, err = readMountFile("self")
if hpmPath != "" { // don't fallback with HOST_PROC_MOUNTINFO
return nil, err
}
// fallback to "/proc/self/..." #1159
lines, useMounts, filename, err = readMountFile(common.HostProc(path.Join("self")))
if err != nil {
return nil, err
}
Expand Down