add disk IoTime on freebsd and fix read & write time calculation #232
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does 2 things.
IoTime
metric to FreeBSDIn regards to number 2, the
Compute()
function was effectively doing nothing. It was convertingBINTIME_SCALE
to auint64
. But because the value is a float < 0, when converted toint64
, it becomes0
. So the function effectively just returned the fieldb.Sec
. This fixes the calculation by preserving the value as a float.Also relatedly, the times were being returned in seconds, when the raw values offer much higher precision than that. Since the linux values are returned in milliseconds, I opted to keep the type (a
uint64
), but am now returning the values measured in milliseconds instead of seconds. (It would probably be a good idea to use atime.Duration
instead ofuint64
)