Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cpu][linux] Add support for logical arg in Counts #640 #628 #644

Merged
merged 2 commits into from
Mar 13, 2019
Merged

[cpu][linux] Add support for logical arg in Counts #640 #628 #644

merged 2 commits into from
Mar 13, 2019

Conversation

Lomanic
Copy link
Collaborator

@Lomanic Lomanic commented Mar 3, 2019

  • move cpu.Counts to OS-specific files
  • implement logical arg in cpu.Counts according to python psutil on Linux

Tested OK on Debian 9 x64

shirou
shirou approved these changes Mar 4, 2019
View reviewed changes
Copy link
Owner

@shirou shirou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR! It works great for my Linux environment. I wrote a small comment, please change if you don't mind.

cpu/cpu_linux.go Outdated Show resolved Hide resolved
Lomanic
Lomanic commented Mar 4, 2019
View reviewed changes
cpu/cpu_linux.go Outdated Show resolved Hide resolved
@Lomanic
[cpu][linux] Remove regexp in Counts
200e5fb 
Also remove some remaining debug print and unnecessary strings.Split
@shirou
Copy link
Owner

shirou commented Mar 10, 2019

LGTM!

@Lomanic Lomanic merged commit ebc97ee into shirou:master Mar 13, 2019
@mznet mznet mentioned this pull request Mar 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirou shirou shirou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lomanic @shirou