[process][darwin] Fix #925 properly and improve some tests #947

Lomanic · 2020-09-29T22:03:40Z

[process][darwin] Fix #925 properly and improve some tests

…roc.pid", PID)

shirou · 2020-09-30T11:56:24Z

sorry, I don't have a Darwin machine but I think the code LGTM

run only them with: go test -bench=. -run=xxx github.com/shirou/gopsutil/process

Lomanic added 2 commits September 29, 2020 23:56

[process][darwin] Fix shirou#925 properly with unix.SysctlRaw("kern.p…

c9c4021

…roc.pid", PID)

[process] Properly test Ppid() against known value

64ba9d0

Lomanic force-pushed the issue925 branch from 9b5ce58 to 041e031 Compare September 29, 2020 22:04

shirou approved these changes Sep 30, 2020

View reviewed changes

Lomanic force-pushed the issue925 branch from 041e031 to 62d5acd Compare October 1, 2020 08:24

[process] Add benchmarks for New(), Name() Ppid()

eaa3481

run only them with: go test -bench=. -run=xxx github.com/shirou/gopsutil/process

Lomanic force-pushed the issue925 branch from 62d5acd to eaa3481 Compare October 1, 2020 08:25

Lomanic merged commit 42136c7 into shirou:master Oct 2, 2020

Provide feedback