Cache Process Parent ID in Windows #948
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a
parent
field inprocess.Process
, that is used as a buffer inprocess_linux.go
but unused inprocess_windows.go
code. As per #818, I wanted to make a suggestion to utilize it to cache ppid value which is returned in anygetFromSnapProcess
call.This change will work only if we assume parent process ID won't change in Windows (and should it change, new value shouldn't be trusted).